[GitHub] [incubator-kvrocks] ShooterIT commented on a diff in pull request #791: Use PutVarInt instead of PutFixed while encoding stream entry value

[GitBox <gi...@apache.org>]

ShooterIT commented on code in PR #791:
URL: https://github.com/apache/incubator-kvrocks/pull/791#discussion_r955552261


##########
src/encoding.cc:
##########
@@ -271,3 +271,77 @@ double DecodeDouble(const char *ptr) {
   memcpy(&value, &decoded, sizeof(value));
   return value;
 }
+
+char* EncodeVarint32(char *dst, uint32_t v) {

Review Comment:
   maybe many conditional judgments in unrolling break pipelining processing, this minor computation doesn't influence performance. And now @torwig implement new code, also is free from license problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org