You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/09 16:31:56 UTC

[GitHub] [pulsar] AnonHxy opened a new pull request, #15999: [test][fix]Fix UT MessageDispatchThrottlingTest#testDispatchRateCompatibility2

AnonHxy opened a new pull request, #15999:
URL: https://github.com/apache/pulsar/pull/15999

   ### Motivation
   
   * https://github.com/apache/pulsar/pull/15986   modiy the `MessageDispatchThrottlingTest#testDispatchRateCompatibility2` and test failure, which throw `Topic is already fenced` exceptions
   
   * The reason can be  located at line:1381
   https://github.com/apache/pulsar/blob/5cbaddcccb7183bedb3e98895c4fb34e84415f9a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L1361-L1382
   
   because `topicPolicies.getReplicationClusters()` is empty if we just new a `Policies`. And then if we call `topic.onPoliciesUpdate` the topic will be deleted
   
   ### Modifications
   
   *  Using `admin.namespaces().getPolicies(namespace)`  instead of `new Policies()`. Because  `topicPolicies#replicationClusters` will be auto created as broker's clusterName if we did't set it manually when creating namespace.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
     
   - [x] `doc-not-needed` 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #15999: [test][fix]Fix UT MessageDispatchThrottlingTest#testDispatchRateCompatibility2

Posted by GitBox <gi...@apache.org>.
merlimat merged PR #15999:
URL: https://github.com/apache/pulsar/pull/15999


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org