You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by erikdw <gi...@git.apache.org> on 2017/05/12 09:30:00 UTC
[GitHub] storm pull request #2112: [STORM-2510] update checkstyle configuration to lo...
GitHub user erikdw opened a pull request:
https://github.com/apache/storm/pull/2112
[STORM-2510] update checkstyle configuration to lower violations
1. Update from checkstyle-6.11.2 to checkstyle-7.7.
2. Tweak google_checks.xml from checkstyle-7.7 to have the following changes that
are more inline with the way the storm code is written:
* 4 space indents instead of 2
* line-length limit is 120 instead of 100
3. Exclude the generated thrift code in storm-client from being checked.
4. Update all maxAllowedViolations to be in-sync with the current number of
violations, through use of the `update-all-pom-violations.bash` script that
is attached to STORM-2510.
NOTE: this also fixes STORM-2507.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/erikdw/storm STORM-2510
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2112
----
commit 88cf6f7b418a6edb9ea32b66382261dd9e2570dd
Author: Erik Weathers <er...@gmail.com>
Date: 2017-05-12T09:25:21Z
[STORM-2510] commit original unmodified google_checks.xml from checkstyle-7.7
Just ran this command:
```
% curl -o storm-buildtools/storm_checkstyle.xml https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-7.7/src/main/resources/google_checks.xml
```
commit 29c761908ec8305d36535c1d2e3d1c0c3d6c95d1
Author: Erik Weathers <er...@gmail.com>
Date: 2017-05-12T09:27:10Z
[STORM-2510] update checkstyle configuration to lower violations
1. Update from checkstyle-6.11.2 to checkstyle-7.7.
2. Tweak google_checks.xml from checkstyle-7.7 to have the following changes that
are more inline with the way the storm code is written:
* 4 space indents instead of 2
* line-length limit is 120 instead of 100
3. Exclude the generated thrift code in storm-client from being checked.
4. Update all maxAllowedViolations to be in-sync with the current number of
violations, through use of the `update-all-pom-violations.bash` script that
is attached to STORM-2510.
NOTE: this also fixes STORM-2507.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2112: [STORM-2510] update checkstyle configuration to lower vio...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2112
Like I said before I am fine with whatever convention we have, so long as we have one.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2112: [STORM-2510] update checkstyle configuration to lower vio...
Posted by erikdw <gi...@git.apache.org>.
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2112
@vinodkc & @revans2 & @hmcc & @srishtyagrawal : please 👀 when you have a chance. This is a follow-up to the [discussions](https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22096038) in PR #2083, and also an offline email thread about the changes in PR #2093.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2112: [STORM-2510] update checkstyle configuration to lo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2112: [STORM-2510] update checkstyle configuration to lower vio...
Posted by erikdw <gi...@git.apache.org>.
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2112
@revans2 : ah, thanks for pointing out the need for license. I copied how google-cloud-intellij is doing it:
* https://github.com/GoogleCloudPlatform/google-cloud-intellij/blob/ba8c85810f65443d9ff411ad30448b377afa6012/google_checks.xml
I also increased the line limit to 140 and adjusted the maxAllowedViolations accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2112: [STORM-2510] update checkstyle configuration to lower vio...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2112
Oops we need a license in `storm-buildtools/storm_checkstyle.xml` or we need to white list it for rat.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2112: [STORM-2510] update checkstyle configuration to lower vio...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/2112
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---