You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2010/02/13 18:04:27 UTC
[jira] Created: (HADOOP-6565)
AbstractDelegationTokenSecretManager.stopThreads() will NPE if called
before startThreads()
AbstractDelegationTokenSecretManager.stopThreads() will NPE if called before startThreads()
-------------------------------------------------------------------------------------------
Key: HADOOP-6565
URL: https://issues.apache.org/jira/browse/HADOOP-6565
Project: Hadoop Common
Issue Type: Bug
Components: security
Affects Versions: 0.22.0
Reporter: Steve Loughran
Priority: Minor
Looking at the code for starting/stopping SecretManagers, it seems to me that {{AbstractDelegationTokenSecretManager.stopThreads()}} assumes that {{tokenRemoverThread}} is never null. That assumption is only valid if {{AbstractDelegationTokenSecretManager.startThreads()}} was called first.
the call to {{tokenRemoverThread.interrupt()}} should be guarded with a check for {{tokenRemoverThread!=null}}
I haven't encountered this in the field yet, but it should be trivial to replicate in a test and then fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6565)
AbstractDelegationTokenSecretManager.stopThreads() will NPE if called
before startThreads()
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833414#action_12833414 ]
Todd Lipcon commented on HADOOP-6565:
-------------------------------------
Dup of HADOOP-6554 I think
> AbstractDelegationTokenSecretManager.stopThreads() will NPE if called before startThreads()
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-6565
> URL: https://issues.apache.org/jira/browse/HADOOP-6565
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 0.22.0
> Reporter: Steve Loughran
> Priority: Minor
>
> Looking at the code for starting/stopping SecretManagers, it seems to me that {{AbstractDelegationTokenSecretManager.stopThreads()}} assumes that {{tokenRemoverThread}} is never null. That assumption is only valid if {{AbstractDelegationTokenSecretManager.startThreads()}} was called first.
> the call to {{tokenRemoverThread.interrupt()}} should be guarded with a check for {{tokenRemoverThread!=null}}
> I haven't encountered this in the field yet, but it should be trivial to replicate in a test and then fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.