You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-dev@jackrabbit.apache.org by Konrad Windszus <kw...@apache.org> on 2022/01/19 14:46:07 UTC

Property "rep:fullname" on rep:User nodes

Hi,
In the default sync handler I found a mapping from "cn" to "rep:fullname" (https://github.com/apache/jackrabbit-oak/blob/91a2b5aa48432ea5349499e8287ea05bcb02fada/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncConfigImpl.java#L91).

The property "rep:fullname" seems to be an arbitrary property name though, as it is not part of the node type definition outlined at https://jackrabbit.apache.org/oak/docs/security/user/default.html#Representation_in_the_Repository.
Also I couldn't find this property name in the Oak codebase except for in the default sync handler (https://github.com/apache/jackrabbit-oak/search?q=rep%3Afullname).

Is there any reason why I should set this property in User nodes or does that only exist for legacy reasons?
Who is expected to read from this property?

Thanks,
Konrad

Re: Property "rep:fullname" on rep:User nodes

Posted by Konrad Windszus <kw...@apache.org>.

Thanks Angela for the quick answer. That was what I assumed.
Konrad

> On 19. Jan 2022, at 16:08, Angela Schreiber <an...@adobe.com.INVALID> wrote:
> 
> Hi Konrad
> 
> The default value doesn't make sense IMHO and should not have been added in the first place.
> It is however covered by the node type of users/groups as they allow for arbitrary properties being written below the user node (or some subtree for that matter).
> 
> I would be a bit reluctant though to drop it without a compelling reason.
> If we conclude in the oak team that is likely not used anywhere and the default value really bothers us, we can obviously drop it.
> 
> Kind regards
> Angela
> ________________________________
> From: Konrad Windszus <kw...@apache.org>
> Sent: Wednesday, January 19, 2022 3:46 PM
> To: oak-dev@jackrabbit.apache.org <oa...@jackrabbit.apache.org>
> Subject: Property "rep:fullname" on rep:User nodes
> 
> Hi,
> In the default sync handler I found a mapping from "cn" to "rep:fullname" (https://github.com/apache/jackrabbit-oak/blob/91a2b5aa48432ea5349499e8287ea05bcb02fada/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncConfigImpl.java#L91).
> 
> The property "rep:fullname" seems to be an arbitrary property name though, as it is not part of the node type definition outlined at https://jackrabbit.apache.org/oak/docs/security/user/default.html#Representation_in_the_Repository.
> Also I couldn't find this property name in the Oak codebase except for in the default sync handler (https://github.com/apache/jackrabbit-oak/search?q=rep%3Afullname).
> 
> Is there any reason why I should set this property in User nodes or does that only exist for legacy reasons?
> Who is expected to read from this property?
> 
> Thanks,
> Konrad
>

Re: Property "rep:fullname" on rep:User nodes

Posted by Angela Schreiber <an...@adobe.com.INVALID>.

Hi Konrad

The default value doesn't make sense IMHO and should not have been added in the first place.
It is however covered by the node type of users/groups as they allow for arbitrary properties being written below the user node (or some subtree for that matter).

I would be a bit reluctant though to drop it without a compelling reason.
If we conclude in the oak team that is likely not used anywhere and the default value really bothers us, we can obviously drop it.

Kind regards
Angela
________________________________
From: Konrad Windszus <kw...@apache.org>
Sent: Wednesday, January 19, 2022 3:46 PM
To: oak-dev@jackrabbit.apache.org <oa...@jackrabbit.apache.org>
Subject: Property "rep:fullname" on rep:User nodes

Hi,
In the default sync handler I found a mapping from "cn" to "rep:fullname" (https://github.com/apache/jackrabbit-oak/blob/91a2b5aa48432ea5349499e8287ea05bcb02fada/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncConfigImpl.java#L91).

The property "rep:fullname" seems to be an arbitrary property name though, as it is not part of the node type definition outlined at https://jackrabbit.apache.org/oak/docs/security/user/default.html#Representation_in_the_Repository.
Also I couldn't find this property name in the Oak codebase except for in the default sync handler (https://github.com/apache/jackrabbit-oak/search?q=rep%3Afullname).

Is there any reason why I should set this property in User nodes or does that only exist for legacy reasons?
Who is expected to read from this property?

Thanks,
Konrad