[GitHub] [flink-kubernetes-operator] SteNicholas commented on a change in pull request #62: [FLINK-26605] Check if JM can serve rest api calls every time before reconcile

[GitBox <gi...@apache.org>]

SteNicholas commented on a change in pull request #62:
URL: https://github.com/apache/flink-kubernetes-operator/pull/62#discussion_r826824807



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##########
@@ -129,6 +129,16 @@ public boolean isJobManagerPortReady(Configuration config) {
         return false;
     }
 
+    public boolean isJobManagerServing(Configuration config) {
+        try (ClusterClient<String> clusterClient = getClusterClient(config)) {
+            clusterClient.listJobs().get(10, TimeUnit.SECONDS);
+            return true;
+        } catch (Exception ignored) {
+        }

Review comment:
       Does this need to log the exception for listing the jobs of the cluster client?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org