You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jmeter.apache.org by matheuscunha <gi...@git.apache.org> on 2017/10/05 17:45:39 UTC

[GitHub] jmeter pull request #315: Fixing bin/jmeter.sh version error, working as exp...

GitHub user matheuscunha opened a pull request:

    https://github.com/apache/jmeter/pull/315

    Fixing bin/jmeter.sh version error, working as expected with Oracle J…

    Java 9 and OpenJDK 9. New binary from Java HotSpot just displays java version "9" which was breaking service initialization.
    
    `+ MINIMAL_VERSION=1.8.0
    ++ awk '{ print $ NF }'
    ++ type java
    + _java=/usr/bin/java
    ++ /usr/bin/java -version
    ++ awk '-F"' '/version/ {print $2}'
    + CURRENT_VERSION=9
    ++ echo 1.8.0
    ++ awk -F. '{ print $2 }'
    + minimal_version=8
    ++ echo 9
    ++ awk -F. '{ print $2 }'
    + current_version=
    + '[' ']'
    + echo 'Not able to find Java executable or version. Please check your Java installation.'
    Not able to find Java executable or version. Please check your Java installation.
    + exit 1`
    
    As you can see, current_version is empty, and can't be checked.
    
    Java version return:
    `java version "9"
    Java(TM) SE Runtime Environment (build 9+181)
    Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matheuscunha/jmeter trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/315.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #315
    
----
commit 6bb3b1d5fcd0339630238498b0aebfa0ef24ed77
Author: Matheus Cunha <ma...@gmail.com>
Date:   2017-10-05T17:40:23Z

    Fixing bin/jmeter.sh version error, working as expected with Oracle Java 9 and OpenJDK 9. New binary from Java HotSpot just displays java version "9" which was breaking service initialization

----


---

[GitHub] jmeter issue #315: Fixing bin/jmeter.sh version error, working as expected w...

Posted by pmouawad <gi...@git.apache.org>.

Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/315
  
    Thanks for your PR.
    But this code has recently been updated to work differently:
    https://github.com/apache/jmeter/blob/trunk/bin/jmeter
    
    We'll be happy to integrate an update for Windows script:
    https://github.com/apache/jmeter/blob/trunk/bin/jmeter.bat
    
    Thanks


---

[GitHub] jmeter issue #315: Fixing bin/jmeter.sh version error, working as expected w...

Posted by pmouawad <gi...@git.apache.org>.

Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/315
  
    Hello, 
    For your information, I used part of your code to handle migration to Java9:
    
    - http://svn.apache.org/viewvc?view=revision&revision=1813017
    
    If you're able to provide the same for windows it would be great.
    
    Thanks
    Regards


---

[GitHub] jmeter pull request #315: Fixing bin/jmeter.sh version error, working as exp...

Posted by matheuscunha <gi...@git.apache.org>.

Github user matheuscunha closed the pull request at:

    https://github.com/apache/jmeter/pull/315


---