[GitHub] [dolphinscheduler] zhuangchong commented on a change in pull request #5628: [Feature-#5565][UI] Global Param passed by sense dependencies

[GitBox <gi...@apache.org>]

zhuangchong commented on a change in pull request #5628:
URL: https://github.com/apache/dolphinscheduler/pull/5628#discussion_r652540268



##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/udp/udp.vue
##########
@@ -202,38 +202,39 @@
        */
       reloadParam () {
         const dag = _.cloneDeep(this.store.state.dag)
-        let fixedParam = []
-        const tasks = this.store.state.dag.tasks
-        for (const task of tasks) {
-          const localParam = task.params ? task.params.localParams : []
-          localParam.forEach(l => {
-            if (!fixedParam.some(f => { return f.prop === l.prop })) {
-              fixedParam.push(Object.assign({
-                ifFixed: true
-              }, l))
-            }
-          })
-        }
+        // let fixedParam = []
+        // const tasks = this.store.state.dag.tasks
+        // for (const task of tasks) {
+        //   const localParam = task.params ? task.params.localParams : []
+        //   localParam.forEach(l => {
+        //     if (!fixedParam.some(f => { return f.prop === l.prop })) {
+        //       fixedParam.push(Object.assign({
+        //         ifFixed: true
+        //       }, l))
+        //     }
+        //   })
+        // }
 
         let globalParams = _.cloneDeep(dag.globalParams)
+        // globalParams = globalParams.map(g => {
+        //   if (fixedParam.some(f => { return g.prop === f.prop })) {
+        //     fixedParam = fixedParam.filter(f => { return g.prop !== f.prop })
+        //     return Object.assign(g, {
+        //       ifFixed: true
+        //     })
+        //   } else {
+        //     return g
+        //   }
+        // })
 
-        globalParams = globalParams.map(g => {
-          if (fixedParam.some(f => { return g.prop === f.prop })) {
-            fixedParam = fixedParam.filter(f => { return g.prop !== f.prop })
-            return Object.assign(g, {
-              ifFixed: true
-            })
-          } else {
-            return g
-          }
-        })
-        let udpList = [...fixedParam, ...globalParams].sort(s => {
-          if (s.ifFixed) {
-            return -1
-          } else {
-            return 1
-          }
-        })
+        // let udpList = [...globalParams].sort(s => {
+        //   if (s.ifFixed) {
+        //     return -1
+        //   } else {
+        //     return 1
+        //   }
+        // })

Review comment:
       Please remove the comment code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org