You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/02 17:02:59 UTC
[GitHub] [arrow] pitrou opened a new pull request #10852: ARROW-13421: [C++][Python] Add CSV convert option to change decimal p…
pitrou opened a new pull request #10852:
URL: https://github.com/apache/arrow/pull/10852
…oint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #10852: ARROW-13421: [C++][Python] Add CSV convert option to change decimal point
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #10852:
URL: https://github.com/apache/arrow/pull/10852#issuecomment-891243450
Hard for me to review without a test in R showing it working ;P
Is this something that fast_float should support?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10852: ARROW-13421: [C++][Python] Add CSV convert option to change decimal point
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10852:
URL: https://github.com/apache/arrow/pull/10852#issuecomment-891184116
https://issues.apache.org/jira/browse/ARROW-13421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lemire commented on pull request #10852: ARROW-13421: [C++][Python] Add CSV convert option to change decimal point
Posted by GitBox <gi...@apache.org>.
lemire commented on pull request #10852:
URL: https://github.com/apache/arrow/pull/10852#issuecomment-891856281
The fast_float library now has support for commas as of release 2.0.0 thanks to a code contribution by @pitrou.
It requires using a distinct function: not `fast_float::from_chars` but `fast_float::from_chars_advanced`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10852: ARROW-13421: [C++][Python] Add CSV convert option to change decimal point
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10852:
URL: https://github.com/apache/arrow/pull/10852#issuecomment-891257098
It doesn't. I'm not sure we want to support emitting such files, either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #10852: ARROW-13421: [C++][Python] Add CSV convert option to change decimal point
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #10852:
URL: https://github.com/apache/arrow/pull/10852#issuecomment-891256731
Possibly scope creep, but does this also work the other way, on csv writing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10852: ARROW-13421: [C++][Python] Add CSV convert option to change decimal point
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10852:
URL: https://github.com/apache/arrow/pull/10852#issuecomment-891244074
@nealrichardson Perhaps you would like to contribute that test? (and the R bindings for the `decimal_point` option)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #10852: ARROW-13421: [C++][Python] Add CSV convert option to change decimal point
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #10852:
URL: https://github.com/apache/arrow/pull/10852#issuecomment-891256255
> @nealrichardson Perhaps you would like to contribute that test? (and the R bindings for the `decimal_point` option)
I'll make a followup JIRA, I don't want to hold this up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou edited a comment on pull request #10852: ARROW-13421: [C++][Python] Add CSV convert option to change decimal point
Posted by GitBox <gi...@apache.org>.
pitrou edited a comment on pull request #10852:
URL: https://github.com/apache/arrow/pull/10852#issuecomment-891244312
> Is this something that fast_float should support?
I don't know... but we need to support it for decimals as well.
edit: opened https://github.com/fastfloat/fast_float/issues/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson edited a comment on pull request #10852: ARROW-13421: [C++][Python] Add CSV convert option to change decimal point
Posted by GitBox <gi...@apache.org>.
nealrichardson edited a comment on pull request #10852:
URL: https://github.com/apache/arrow/pull/10852#issuecomment-891256255
> @nealrichardson Perhaps you would like to contribute that test? (and the R bindings for the `decimal_point` option)
I'll make a followup JIRA, I don't want to hold this up (done: ARROW-13531)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10852: ARROW-13421: [C++][Python] Add CSV convert option to change decimal point
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10852:
URL: https://github.com/apache/arrow/pull/10852#issuecomment-891244312
> Is this something that fast_float should support?
I don't know... but we need to support it for decimals as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org