You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/09/15 03:21:45 UTC
[GitHub] [incubator-echarts] wf123537200 opened a new pull request #13282: fix(tooltipView): radar.tooltip.trigger.axis no effect, fix 10537
wf123537200 opened a new pull request #13282:
URL: https://github.com/apache/incubator-echarts/pull/13282
[pr12637](https://github.com/apache/incubator-echarts/pull/12637) move to ```next``` branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] wf123537200 closed pull request #13282: fix(tooltipView): radar.tooltip.trigger.axis no effect, fix 10537
Posted by GitBox <gi...@apache.org>.
wf123537200 closed pull request #13282:
URL: https://github.com/apache/incubator-echarts/pull/13282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13282: fix(tooltipView): radar.tooltip.trigger.axis no effect, fix 10537
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13282:
URL: https://github.com/apache/incubator-echarts/pull/13282#issuecomment-692438790
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on a change in pull request #13282: fix(tooltipView): radar.tooltip.trigger.axis no effect, fix 10537
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #13282:
URL: https://github.com/apache/incubator-echarts/pull/13282#discussion_r503029886
##########
File path: src/component/tooltip/TooltipView.ts
##########
@@ -628,8 +628,9 @@ class TooltipView extends ComponentView {
this._tooltipModel
]);
+ // fix 10537
const tooltipTrigger = tooltipModel.get('trigger');
- if (tooltipTrigger != null && tooltipTrigger !== 'item') {
+ if (!tooltipTrigger || tooltipTrigger === 'none') {
return;
}
Review comment:
This change only makes tooltip trigger on the item even if it's configured as `axis`. It will break other series and can't get the expected result of radar. In radar, the expected result is to show all the values of one indicator if tooltip.trigger is `axis`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] wf123537200 commented on a change in pull request #13282: fix(tooltipView): radar.tooltip.trigger.axis no effect, fix 10537
Posted by GitBox <gi...@apache.org>.
wf123537200 commented on a change in pull request #13282:
URL: https://github.com/apache/incubator-echarts/pull/13282#discussion_r505422595
##########
File path: src/component/tooltip/TooltipView.ts
##########
@@ -628,8 +628,9 @@ class TooltipView extends ComponentView {
this._tooltipModel
]);
+ // fix 10537
const tooltipTrigger = tooltipModel.get('trigger');
- if (tooltipTrigger != null && tooltipTrigger !== 'item') {
+ if (!tooltipTrigger || tooltipTrigger === 'none') {
return;
}
Review comment:
> I think this change only makes tooltip trigger on the item even if it's configured as `axis`. It will break other series and can't get the expected result of radar. In radar, the expected result is to show all the values of one indicator if tooltip.trigger is `axis`
got it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on a change in pull request #13282: fix(tooltipView): radar.tooltip.trigger.axis no effect, fix 10537
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #13282:
URL: https://github.com/apache/incubator-echarts/pull/13282#discussion_r503029886
##########
File path: src/component/tooltip/TooltipView.ts
##########
@@ -628,8 +628,9 @@ class TooltipView extends ComponentView {
this._tooltipModel
]);
+ // fix 10537
const tooltipTrigger = tooltipModel.get('trigger');
- if (tooltipTrigger != null && tooltipTrigger !== 'item') {
+ if (!tooltipTrigger || tooltipTrigger === 'none') {
return;
}
Review comment:
I think this change only makes tooltip trigger on the item even if it's configured as `axis`. It will break other series and can't get the expected result of radar. In radar, the expected result is to show all the values of one indicator if tooltip.trigger is `axis`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org