You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "klesh (via GitHub)" <gi...@apache.org> on 2023/02/10 01:35:48 UTC

[GitHub] [incubator-devlake] klesh opened a new issue, #4375: [Bug][github] Github test connection not working correctly

klesh opened a new issue, #4375:
URL: https://github.com/apache/incubator-devlake/issues/4375

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   Test Connection always fails after refactoring.
   
   It is caused by the Test Connection passing the `conn` struct directly into `NewApiClientFromConnection` which should be a pointer instead, offending code:
   https://github.com/apache/incubator-devlake/blob/d2815d5ffe4168d0080237f3c0f5ebc2240032b6/backend/plugins/github/api/connection.go#L52
   
   
   ### What do you expect to happen
   
   Github  test connection should work
   
   ### How to reproduce
   
   input valid token for github test connection, see error
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   main
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] likyh closed issue #4375: [Bug][github] Github test connection not working correctly

Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh closed issue #4375: [Bug][github] Github test connection not working correctly
URL: https://github.com/apache/incubator-devlake/issues/4375


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org