You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/03/27 07:16:55 UTC

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3239: KVM: Fix agents dont reconnect post maintenance

rhtyd commented on a change in pull request #3239: KVM: Fix agents dont reconnect post maintenance
URL: https://github.com/apache/cloudstack/pull/3239#discussion_r269429660
 
 

 ##########
 File path: agent/src/com/cloud/agent/Agent.java
 ##########
 @@ -606,9 +606,8 @@ protected void processRequest(final Request request, final Link link) {
                         System.exit(1);
                         return;
                     } else if (cmd instanceof MaintainCommand) {
-                        s_logger.debug("Received maintainCommand");
-                        cancelTasks();
-                        _reconnectAllowed = false;
+                        s_logger.debug("Received maintainCommand, do not cancel current tasks");
+                        _reconnectAllowed = true;
 
 Review comment:
   It's possible reconnectedAllowed need not be set to true or false, i.e. remove the line?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services