You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/01/12 17:47:51 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #87: checkpatch remove -m 86 option since nxstyle can determine the max li…
xiaoxiang781216 opened a new pull request #87: checkpatch remove -m 86 option since nxstyle can determine the max li…
URL: https://github.com/apache/incubator-nuttx/pull/87
…ne length smart now
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #87: checkpatch remove -m 86 option since nxstyle can determine the max li…
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #87: checkpatch remove -m 86 option since nxstyle can determine the max li…
URL: https://github.com/apache/incubator-nuttx/pull/87#discussion_r365599707
##########
File path: tools/checkpatch.sh
##########
@@ -30,7 +30,7 @@ usage() {
}
check_file() {
- $TOOLDIR/nxstyle -m 86 $@ 2>&1
+ $TOOLDIR/nxstyle $@ 2>&1
Review comment:
With a default line width of 78, to get the same behavior, you would need -m 8
Do you want to change that, or commit it as is. You will only get a few more errors of long lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #87: checkpatch remove -m 86 option since nxstyle can determine the max li…
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #87: checkpatch remove -m 86 option since nxstyle can determine the max li…
URL: https://github.com/apache/incubator-nuttx/pull/87#discussion_r365599707
##########
File path: tools/checkpatch.sh
##########
@@ -30,7 +30,7 @@ usage() {
}
check_file() {
- $TOOLDIR/nxstyle -m 86 $@ 2>&1
+ $TOOLDIR/nxstyle $@ 2>&1
Review comment:
With a default line width of 78, to get the same behavior, you would need -m 8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #87: checkpatch remove -m 86 option since nxstyle can determine the max li…
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #87: checkpatch remove -m 86 option since nxstyle can determine the max li…
URL: https://github.com/apache/incubator-nuttx/pull/87
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services