You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by Glen Daniels <gl...@thoughtcraft.com> on 2009/01/04 15:28:21 UTC
Re: [jira] Created: (WSCOMMONS-427)
StreamingOMSerializer#serializeXOPInclude doesn't decode cid: URLs
Hi Andreas:
You didn't mark this as a blocker, but it sounds fairly serious. Should
we hold 1.2.8 until this is fixed?
--Glen
Andreas Veithen (JIRA) wrote:
> StreamingOMSerializer#serializeXOPInclude doesn't decode cid: URLs
> ------------------------------------------------------------------
>
> Key: WSCOMMONS-427
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-427
> Project: WS-Commons
> Issue Type: Bug
> Components: AXIOM
> Reporter: Andreas Veithen
> Assignee: Andreas Veithen
> Priority: Critical
>
>
> StreamingOMSerializer#serializeXOPInclude contains the following code:
>
> String cid = reader.getAttributeValue(null, "href");
> DataHandler dh = getDataHandler(cid, (OMAttachmentAccessor) reader);
> if (dh == null) {
> return false;
> }
>
> OMFactory omFactory = OMAbstractFactory.getOMFactory();
> OMText omText = omFactory.createOMText(dh, true);
> omText.setContentID(cid);
>
> This means that the contentId set on the OMText instance is incorrect: it is actually not the Content-ID, but the cid: URL. This implies that the generated XOP/MTOM message is incorrect.
>
> The code in serializeXOPInclude should decode the href attribute in the same way as XOPAwareStAXOMBuilder#createOMElement (which uses ElementHelper.getContentID).
>
Re: [jira] Created: (WSCOMMONS-427) StreamingOMSerializer#serializeXOPInclude doesn't decode cid: URLs
Posted by Andreas Veithen <an...@gmail.com>.
+1
Andreas
On Sun, Jan 4, 2009 at 15:28, Glen Daniels <gl...@thoughtcraft.com> wrote:
> Hi Andreas:
>
> You didn't mark this as a blocker, but it sounds fairly serious. Should
> we hold 1.2.8 until this is fixed?
>
> --Glen
>
> Andreas Veithen (JIRA) wrote:
>> StreamingOMSerializer#serializeXOPInclude doesn't decode cid: URLs
>> ------------------------------------------------------------------
>>
>> Key: WSCOMMONS-427
>> URL: https://issues.apache.org/jira/browse/WSCOMMONS-427
>> Project: WS-Commons
>> Issue Type: Bug
>> Components: AXIOM
>> Reporter: Andreas Veithen
>> Assignee: Andreas Veithen
>> Priority: Critical
>>
>>
>> StreamingOMSerializer#serializeXOPInclude contains the following code:
>>
>> String cid = reader.getAttributeValue(null, "href");
>> DataHandler dh = getDataHandler(cid, (OMAttachmentAccessor) reader);
>> if (dh == null) {
>> return false;
>> }
>>
>> OMFactory omFactory = OMAbstractFactory.getOMFactory();
>> OMText omText = omFactory.createOMText(dh, true);
>> omText.setContentID(cid);
>>
>> This means that the contentId set on the OMText instance is incorrect: it is actually not the Content-ID, but the cid: URL. This implies that the generated XOP/MTOM message is incorrect.
>>
>> The code in serializeXOPInclude should decode the href attribute in the same way as XOPAwareStAXOMBuilder#createOMElement (which uses ElementHelper.getContentID).
>>
>