You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Arpit Agarwal (JIRA)" <ji...@apache.org> on 2016/11/09 02:29:58 UTC
[jira] [Commented] (HDFS-9371) Code cleanup for DatanodeManager
[ https://issues.apache.org/jira/browse/HDFS-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15649590#comment-15649590 ]
Arpit Agarwal commented on HDFS-9371:
-------------------------------------
It looks like this can be committed to branch-2.8 with trivially resolved conflicts. [~jingzhao], do you recall if there is any potential issue merging this to branch-2.8 (like implicit dependency)? Thanks!
{code}
<<<<<<< HEAD
if (shouldCountVersion(dn)) {
Integer num = versionCount.get(dn.getSoftwareVersion());
||||||| parent of e0abb0a... HDFS-9371. Code cleanup for DatanodeManager. Contributed by Jing Zhao.
// Check isAlive too because right after removeDatanode(),
// isDatanodeDead() is still true
if(shouldCountVersion(dn)) {
Integer num = versionCount.get(dn.getSoftwareVersion());
=======
// Check isAlive too because right after removeDatanode(),
// isDatanodeDead() is still true
if (shouldCountVersion(dn)) {
Integer num = datanodesSoftwareVersions.get(dn.getSoftwareVersion());
>>>>>>> e0abb0a... HDFS-9371. Code cleanup for DatanodeManager. Contributed by Jing Zhao.
{code}
> Code cleanup for DatanodeManager
> --------------------------------
>
> Key: HDFS-9371
> URL: https://issues.apache.org/jira/browse/HDFS-9371
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Fix For: 2.9.0, 3.0.0-alpha1
>
> Attachments: HDFS-9371.000.patch, HDFS-9371.001.patch, HDFS-9371.002.patch, HDFS-9371.003.patch, HDFS-9371.004.patch
>
>
> Some code cleanup for DatanodeManager. The main changes include:
> # make the synchronization of {{datanodeMap}} and {{datanodesSoftwareVersions}} consistent
> # remove unnecessary lock in {{handleHeartbeat}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org