You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by vi...@apache.org on 2022/02/10 13:19:28 UTC
[superset] branch master updated: fix: dataset modal doesn't work in dev mode (#18658)
This is an automated email from the ASF dual-hosted git repository.
villebro pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 8212975 fix: dataset modal doesn't work in dev mode (#18658)
8212975 is described below
commit 82129753b07730a439fd88f26332a48692137044
Author: Stephen Liu <75...@qq.com>
AuthorDate: Thu Feb 10 21:17:16 2022 +0800
fix: dataset modal doesn't work in dev mode (#18658)
* fix: dataset modal in dev mode
* remove cache
* add comment
---
superset-frontend/webpack.config.js | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/superset-frontend/webpack.config.js b/superset-frontend/webpack.config.js
index 55f0122..06f6825 100644
--- a/superset-frontend/webpack.config.js
+++ b/superset-frontend/webpack.config.js
@@ -344,6 +344,14 @@ const config = {
],
use: [babelLoader],
},
+ // react-hot-loader use "ProxyFacade", which is a wrapper for react Component
+ // see https://github.com/gaearon/react-hot-loader/issues/1311
+ // TODO: refactor recurseReactClone
+ {
+ test: /\.js$/,
+ include: /node_modules\/react-dom/,
+ use: ['react-hot-loader/webpack'],
+ },
{
test: /\.css$/,
include: [APP_DIR, /superset-ui.+\/src/],