You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2019/09/06 17:53:52 UTC
[GitHub] [logging-log4j2] garydgregory commented on a change in pull request
#306: [LOG4J2-2678] Add LogEvent timestamp to Kafka ProducerRecord
garydgregory commented on a change in pull request #306: [LOG4J2-2678] Add LogEvent timestamp to Kafka ProducerRecord
URL: https://github.com/apache/logging-log4j2/pull/306#discussion_r321844534
##########
File path: log4j-kafka/src/main/java/org/apache/logging/log4j/kafka/appender/KafkaAppender.java
##########
@@ -83,7 +83,7 @@ public boolean isSyncSend() {
return syncSend;
}
- public boolean isSendTimestamp() { return sendTimestamp; }
+ public boolean isSendEventTimestamp() { return sendEventTimestamp; }
Review comment:
This needs to be split into >1 line to match the coding style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services