You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/09 15:13:11 UTC
[GitHub] [tvm] onkar-sima-ai opened a new pull request #9478: added tests for quantized tflite sin operator
onkar-sima-ai opened a new pull request #9478:
URL: https://github.com/apache/tvm/pull/9478
https://github.com/apache/tvm/issues/9187
I have added support for quantized SIN tflite operator and wrote tests for the same.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] onkar-sima-ai edited a comment on pull request #9478: added tests for quantized tflite sin operator
Posted by GitBox <gi...@apache.org>.
onkar-sima-ai edited a comment on pull request #9478:
URL: https://github.com/apache/tvm/pull/9478#issuecomment-964538675
Hi @leandron I am not sure if the failure of CI has to do anything with the changes I introduced.
Is this a race condition?
Can you please help me understand why CI failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron merged pull request #9478: added tests for quantized tflite sin operator
Posted by GitBox <gi...@apache.org>.
leandron merged pull request #9478:
URL: https://github.com/apache/tvm/pull/9478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] onkar-sima-ai commented on pull request #9478: added tests for quantized tflite sin operator
Posted by GitBox <gi...@apache.org>.
onkar-sima-ai commented on pull request #9478:
URL: https://github.com/apache/tvm/pull/9478#issuecomment-968130254
Hi @leandron The CI has passed, Can you please merge this PR https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-9478/4/pipeline/269/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] onkar-sima-ai commented on pull request #9478: added tests for quantized tflite sin operator
Posted by GitBox <gi...@apache.org>.
onkar-sima-ai commented on pull request #9478:
URL: https://github.com/apache/tvm/pull/9478#issuecomment-968069892
Hi @leandron
I ran the failing test in my local, and it passed.
I was not able to reproduce the same error.
So I rebased and pushed again.
Can you please let me know if we should wait to see if CI passes or Is there something wrong with my PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on a change in pull request #9478: added tests for quantized tflite sin operator
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #9478:
URL: https://github.com/apache/tvm/pull/9478#discussion_r745751993
##########
File path: tests/python/frontend/tflite/test_forward.py
##########
@@ -1850,6 +1878,16 @@ def _test_tan(data):
return _test_unary_elemwise(math_ops.tan, data)
+#######################################################################
+# Sqrt
+# ----
+
+
+def _test_sqrt(data):
+ """One iteration of sqrt"""
+ return _test_unary_elemwise(math_ops.sqrt, data)
+
+
Review comment:
This block above seems unrelated to this PR, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] onkar-sima-ai commented on a change in pull request #9478: added tests for quantized tflite sin operator
Posted by GitBox <gi...@apache.org>.
onkar-sima-ai commented on a change in pull request #9478:
URL: https://github.com/apache/tvm/pull/9478#discussion_r745820253
##########
File path: tests/python/frontend/tflite/test_forward.py
##########
@@ -1850,6 +1878,16 @@ def _test_tan(data):
return _test_unary_elemwise(math_ops.tan, data)
+#######################################################################
+# Sqrt
+# ----
+
+
+def _test_sqrt(data):
+ """One iteration of sqrt"""
+ return _test_unary_elemwise(math_ops.sqrt, data)
+
+
Review comment:
Yes I will remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] onkar-sima-ai edited a comment on pull request #9478: added tests for quantized tflite sin operator
Posted by GitBox <gi...@apache.org>.
onkar-sima-ai edited a comment on pull request #9478:
URL: https://github.com/apache/tvm/pull/9478#issuecomment-964538675
Hi @leandron I am not sure if the failure of CI has to do anything with the changes I introduced.
Is this an expected condition?
Can you please help me understand why CI failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] onkar-sima-ai commented on pull request #9478: added tests for quantized tflite sin operator
Posted by GitBox <gi...@apache.org>.
onkar-sima-ai commented on pull request #9478:
URL: https://github.com/apache/tvm/pull/9478#issuecomment-964538675
Hi @leandron I am not sure the failure of CI has to do anything with the changes I introduced.
Is this an expected condition?
Can you please help me understand why CI failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org