You are viewing a plain text version of this content. The canonical link for it is here.

Posted to mapreduce-issues@hadoop.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2015/01/29 07:34:35 UTC

[jira] [Commented] (MAPREDUCE-5800) Use Job#getInstance instead of deprecated constructors

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296449#comment-14296449 ] 

Harsh J commented on MAPREDUCE-5800:
------------------------------------

This patch shouldn't really be the culprit behind the findbugs warnings (a result of another change ongoing at the time). The approach looks fine to me. Could you re-eval and resubmit a trunk patch (to cover any newly added code that uses this deprecated API), so we may commit it in?

> Use Job#getInstance instead of deprecated constructors
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-5800
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5800
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 2.3.0, 2.6.0
>            Reporter: Akira AJISAKA
>            Assignee: Akira AJISAKA
>            Priority: Minor
>              Labels: newbie
>         Attachments: MAPREDUCE-5800.2.patch, MAPREDUCE-5800.patch
>
>
> There're some methods calling deprecated constructors such as {{new Job()}}, which causes javac warnings.
> We should use {{Job.getInstance()}} to get an instance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)