You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Swapan Shridhar <ss...@hortonworks.com> on 2017/02/15 20:47:28 UTC
Review Request 56718: AMBARI-20033. Typecasting to 'long' from earlier
'float', before setting them the following configs for recommendation : (1).
'llap_concurrency',
(2). 'llap_concurrency' max value and (3). 'hive.llap.daemon.num.executors'
max value.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56718/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
Bugs: AMBARI-20033
https://issues.apache.org/jira/browse/AMBARI-20033
Repository: ambari
Description
-------
AMBARI-20033. Typecasting to 'long' from earlier 'float', before setting them the following configs for recommendation : (1). 'llap_concurrency', (2). 'llap_concurrency' max value and (3). 'hive.llap.daemon.num.executors' max value.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 4de9a41
Diff: https://reviews.apache.org/r/56718/diff/
Testing
-------
Tested on cluster
Python UT passes.
Thanks,
Swapan Shridhar
Re: Review Request 56718: AMBARI-20033. Typecasting to 'long' from
earlier
'float', before setting them the following configs for recommendation : (1).
'llap_concurrency',
(2). 'llap_concurrency' max value and (3). 'hive.llap.daemon.num.executors'
max value.
Posted by Swapan Shridhar <ss...@hortonworks.com>.
> On Feb. 15, 2017, 8:53 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, line 1037
> > <https://reviews.apache.org/r/56718/diff/1/?file=1634858#file1634858line1037>
> >
> > Please also make this change in YARN 3.0.0.3.0's service advisor.
Done.
- Swapan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56718/#review165755
-----------------------------------------------------------
On Feb. 15, 2017, 8:47 p.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56718/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 8:47 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
>
>
> Bugs: AMBARI-20033
> https://issues.apache.org/jira/browse/AMBARI-20033
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-20033. Typecasting to 'long' from earlier 'float', before setting them the following configs for recommendation : (1). 'llap_concurrency', (2). 'llap_concurrency' max value and (3). 'hive.llap.daemon.num.executors' max value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 4de9a41
>
> Diff: https://reviews.apache.org/r/56718/diff/
>
>
> Testing
> -------
>
> Tested on cluster
> Python UT passes.
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 56718: AMBARI-20033. Typecasting to 'long' from
earlier
'float', before setting them the following configs for recommendation : (1).
'llap_concurrency',
(2). 'llap_concurrency' max value and (3). 'hive.llap.daemon.num.executors'
max value.
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56718/#review165755
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 1037)
<https://reviews.apache.org/r/56718/#comment237617>
Please also make this change in YARN 3.0.0.3.0's service advisor.
- Alejandro Fernandez
On Feb. 15, 2017, 8:47 p.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56718/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 8:47 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
>
>
> Bugs: AMBARI-20033
> https://issues.apache.org/jira/browse/AMBARI-20033
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-20033. Typecasting to 'long' from earlier 'float', before setting them the following configs for recommendation : (1). 'llap_concurrency', (2). 'llap_concurrency' max value and (3). 'hive.llap.daemon.num.executors' max value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 4de9a41
>
> Diff: https://reviews.apache.org/r/56718/diff/
>
>
> Testing
> -------
>
> Tested on cluster
> Python UT passes.
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 56718: AMBARI-20033. Typecasting to 'long' from
earlier
'float', before setting them the following configs for recommendation : (1).
'llap_concurrency',
(2). 'llap_concurrency' max value and (3). 'hive.llap.daemon.num.executors'
max value.
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56718/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 9:21 p.m.)
Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
Changes
-------
Updated changed in Service Advisor.
Bugs: AMBARI-20033
https://issues.apache.org/jira/browse/AMBARI-20033
Repository: ambari
Description
-------
AMBARI-20033. Typecasting to 'long' from earlier 'float', before setting them the following configs for recommendation : (1). 'llap_concurrency', (2). 'llap_concurrency' max value and (3). 'hive.llap.daemon.num.executors' max value.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py aecf1e3
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 4de9a41
Diff: https://reviews.apache.org/r/56718/diff/
Testing
-------
Tested on cluster
Python UT passes.
Thanks,
Swapan Shridhar