You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Brian McDevitt (Code Review)" <ge...@cloudera.org> on 2019/01/30 22:31:52 UTC
[kudu-CR] KUDU-2411: Altered binary jar extractor API
Brian McDevitt has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12319
Change subject: KUDU-2411: Altered binary jar extractor API
......................................................................
KUDU-2411: Altered binary jar extractor API
The jar extractor API now handles situations where a ZipFileSystem has
not yet been created by the JVM. This prevents exceptions on the first
call to `Paths.get(URI uri)` where the uri would be handled by a
ZipFileSysteemProvider.
Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
2 files changed, 10 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/12319/1
--
To view, visit http://gerrit.cloudera.org:8080/12319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
[kudu-CR] KUDU-2411: Altered binary jar extractor API
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12319
to look at the new patch set (#3).
Change subject: KUDU-2411: Altered binary jar extractor API
......................................................................
KUDU-2411: Altered binary jar extractor API
The jar extractor API now handles situations where a ZipFileSystem has
not yet been created by the JVM. This prevents exceptions on the first
call to `Paths.get(URI uri)` where the uri would be handled by a
ZipFileSystemProvider.
Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
2 files changed, 12 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/12319/3
--
To view, visit http://gerrit.cloudera.org:8080/12319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 3
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-2411: Altered binary jar extractor API
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12319 )
Change subject: KUDU-2411: Altered binary jar extractor API
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12319/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12319/3//COMMIT_MSG@9
PS3, Line 9: The jar extractor API now handles situations where a ZipFileSystem has
Is this explanation still accurate?
--
To view, visit http://gerrit.cloudera.org:8080/12319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 3
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 31 Jan 2019 00:38:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Altered binary jar extractor API
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12319 )
Change subject: KUDU-2411: Altered binary jar extractor API
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 4
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 31 Jan 2019 20:09:21 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Altered binary jar extractor API
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12319 )
Change subject: KUDU-2411: Altered binary jar extractor API
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12319/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java:
http://gerrit.cloudera.org:8080/#/c/12319/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@140
PS2, Line 140: if (Files.notExists(target)) {
can we add something like this:
checkArgument("jar".equals(src.getScheme()), "src URI must use a jar: scheme");
Or if not validation then at least a Javadoc comment about how we expect a jar: URI scheme?
http://gerrit.cloudera.org:8080/#/c/12319/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@145
PS2, Line 145: env.put("create", "true");
Why do we want to create a new zip file if one does not exist? Per https://docs.oracle.com/javase/7/docs/technotes/guides/io/fsp/zipfilesystemproviderprops.html
--
To view, visit http://gerrit.cloudera.org:8080/12319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 2
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 30 Jan 2019 22:47:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Altered binary jar extractor API
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12319 )
Change subject: KUDU-2411: Altered binary jar extractor API
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 4
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 31 Jan 2019 19:18:38 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Altered binary jar extractor API
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12319
to look at the new patch set (#2).
Change subject: KUDU-2411: Altered binary jar extractor API
......................................................................
KUDU-2411: Altered binary jar extractor API
The jar extractor API now handles situations where a ZipFileSystem has
not yet been created by the JVM. This prevents exceptions on the first
call to `Paths.get(URI uri)` where the uri would be handled by a
ZipFileSystemProvider.
Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
2 files changed, 10 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/12319/2
--
To view, visit http://gerrit.cloudera.org:8080/12319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 2
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-2411: Altered binary jar extractor API
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12319 )
Change subject: KUDU-2411: Altered binary jar extractor API
......................................................................
KUDU-2411: Altered binary jar extractor API
The jar extractor API now supports situations where a ZipFileSystem for
the jar is not already created. Previously, a
FileSystemNotFoundException would be thrown when calling
`Paths.get(URI)` when the URI referred a jar without an existing
ZipFileSystem.
Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
Reviewed-on: http://gerrit.cloudera.org:8080/12319
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
2 files changed, 11 insertions(+), 7 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 5
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-2411: Altered binary jar extractor API
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12319 )
Change subject: KUDU-2411: Altered binary jar extractor API
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12319/3/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java:
http://gerrit.cloudera.org:8080/#/c/12319/3/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@147
PS3, Line 147: env.put("create", "false");
nit: this is the default so this line is not needed
--
To view, visit http://gerrit.cloudera.org:8080/12319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 3
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 31 Jan 2019 00:36:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Altered binary jar extractor API
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12319 )
Change subject: KUDU-2411: Altered binary jar extractor API
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12319/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java:
http://gerrit.cloudera.org:8080/#/c/12319/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@140
PS2, Line 140: if (Files.notExists(target)) {
> can we add something like this:
Done
http://gerrit.cloudera.org:8080/#/c/12319/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@145
PS2, Line 145: env.put("create", "true");
> Why do we want to create a new zip file if one does not exist? Per https://
Done
--
To view, visit http://gerrit.cloudera.org:8080/12319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 2
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 31 Jan 2019 00:32:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Altered binary jar extractor API
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12319
to look at the new patch set (#4).
Change subject: KUDU-2411: Altered binary jar extractor API
......................................................................
KUDU-2411: Altered binary jar extractor API
The jar extractor API now supports situations where a ZipFileSystem for
the jar is not already created. Previously, a
FileSystemNotFoundException would be thrown when calling
`Paths.get(URI)` when the URI referred a jar without an existing
ZipFileSystem.
Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
2 files changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/12319/4
--
To view, visit http://gerrit.cloudera.org:8080/12319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 4
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>