You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by linwen <gi...@git.apache.org> on 2017/02/27 03:21:23 UTC
[GitHub] incubator-hawq pull request #1146: HAWQ-1355. Fix namespace check may occur ...
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/1146
HAWQ-1355. Fix namespace check may occur multiple times in first query.
Please review, thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/linwen/incubator-hawq hawq-1355
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1146
----
commit ad197031dd017fe213e9d47f499df8fc913a489b
Author: Wen Lin <wl...@pivotal.io>
Date: 2017-02-27T03:14:16Z
HAWQ-1355. Fix namespace check may occur multiple times in first query.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1146: HAWQ-1355. Fix namespace check may occur multipl...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1146
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1146: HAWQ-1355. Fix namespace check may occur ...
Posted by linwen <gi...@git.apache.org>.
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1146
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1146: HAWQ-1355. Fix namespace check may occur ...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1146#discussion_r103140449
--- Diff: src/test/feature/UDF/ans/function_basics.ranger.ans.planner ---
@@ -1045,7 +1133,7 @@ SELECT outer(0);
(1 row)
SELECT outer(0) FROM foo;
-psql:/tmp/TestUDF_TestUDFBasics.sql:423: ERROR: function inner(integer) does not exist
+psql:/tmp/TestUDF_TestUDFBasics.sql:423: ERROR: function inner(integer) does not exist (seg2 localhost:40000 pid=63812)
--- End diff --
(seg2 localhost:40000 pid=63812) should be handled by init_file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1146: HAWQ-1355. Fix namespace check may occur multipl...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/1146
I'm wondering whether rename *.ans.orca
<https://github.com/apache/incubator-hawq/pull/1146#diff-6d2d67ad13a2a11e3e525ec0fff5be11>
->
*.orca.ans and for *.ans.planner -> *.planner.ans. This helps potential
wildcard processing in the future.
The line number could change again with code change. Maybe you could use
the init_file mechanism to avoid some ans file change.
2017-02-27 11:40 GMT+08:00 Xiang Sheng <no...@github.com>:
> *@stanlyxiang* approved this pull request.
>
> +1
>
> \u2014
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-hawq/pull/1146#pullrequestreview-23908958>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AHI5jPjTOvN3urj0lPpHuxT46yZfcEU-ks5rgkWRgaJpZM4MMpw9>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1146: HAWQ-1355. Fix namespace check may occur multipl...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1146
@paul-guo- This PR already use init_file, please check incubator-hawq/src/test/feature/lib/global_init_file for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---