You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by anthonycorbacho <gi...@git.apache.org> on 2016/11/16 07:58:12 UTC

[GitHub] zeppelin pull request #1646: ZEPPELIN-1672 - Fix import note

GitHub user anthonycorbacho opened a pull request:

    https://github.com/apache/zeppelin/pull/1646

    ZEPPELIN-1672 - Fix import note

    ### What is this PR for?
    Importing note from github doenst work, instead you will have the following error
    ```
    XMLHttpRequest cannot load xxxx/note.json. A wildcard '*' cannot be used in the 'Access-Control-Allow-Origin' header when the credentials flag is true.
    Origin 'http://localhost:9000' is therefore not allowed access. The credentials mode of an XMLHttpRequest is controlled by the withCredentials attribute.
    ```
    
    ### What type of PR is it?
    [Bug Fix | Hot Fix ]
    
    ### Todos
    * [x] - Rework how front end get json resource.
    
    ### What is the Jira issue?
    * [ZEPPELIN-1672](https://issues.apache.org/jira/browse/ZEPPELIN-1672)
    
    ### How should this be tested?
    Get a [note](https://raw.githubusercontent.com/apache/zeppelin/master/notebook/2C2AUG798/note.json) from github, and try to import it.
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anthonycorbacho/incubator-zeppelin fix/ImportNotebook

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1646.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1646
    
----
commit 559d009d8f95213d617eacc3555f247823292f00
Author: Anthony Corbacho <co...@gmail.com>
Date:   2016-11-16T07:52:56Z

    ZEPPELIN-1672 - Fix import notebook front end feature

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1646: [ZEPPELIN-1672] - Fix import note

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1646


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1646: [ZEPPELIN-1672] - Fix import note

Posted by anthonycorbacho <gi...@git.apache.org>.

Github user anthonycorbacho commented on the issue:

    https://github.com/apache/zeppelin/pull/1646
  
    @khalidhuseynov i am re triggering travis and merging as a hot fix after that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1646: [ZEPPELIN-1672] - Fix import note

Posted by khalidhuseynov <gi...@git.apache.org>.

Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/1646
  
    tested locally and solves the issue with import, LGTM! CI failure is irrelevant with selenium profile flaky test below:
    ```
    Tests in error: 
      ParagraphActionsIT.testEditOnDoubleClick:443 � ElementNotVisible Element is no...
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---