You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/03 06:05:28 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #953: x86_64: Make sure to clone ap list in vasprintf

xiaoxiang781216 commented on a change in pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#discussion_r419053662



##########
File path: libs/libc/stdio/lib_vasprintf.c
##########
@@ -58,7 +58,7 @@
 #define ap1 ap
 #define ap2 ap
 
-#if defined(CONFIG_ARCH_X86)
+#if defined(CONFIG_ARCH_X86) || defined(CONFIG_ARCH_X86_64)

Review comment:
       Should we change like vsyslog to avoid the same problem happen on the new arch:
   #ifdef va_copy
         va_list copy;
   
         va_copy(copy, ap);
         nx_vsyslog(priority, fmt, &copy);
         va_end(copy);
   #else
         nx_vsyslog(priority, fmt, &ap);
   #endif
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org