[GitHub] [sling-org-apache-sling-feature-cpconverter] kaushalmall commented on a change in pull request #28: Feature Converter doesn't cleanup after itself

[GitBox <gi...@apache.org>]

kaushalmall commented on a change in pull request #28:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/28#discussion_r431302891



##########
File path: src/main/java/org/apache/sling/feature/cpconverter/cli/ShutDownHook.java
##########
@@ -76,4 +82,15 @@ public void run() {
         logger.info("+-----------------------------------------------------+");
     }
 
+    private void cleanUp(){
+        String tmpDir = System.getProperty("java.io.tmpdir");
+        logger.info("Cleaning up tmp directories {}, {}", tmpDir + "sub-content-packages", tmpDir + "syntethic-content-packages" );
+
+        try {
+            FileUtils.deleteDirectory( new File (tmpDir, "syntethic-content-packages") );
+            FileUtils.deleteDirectory( new File(tmpDir, "sub-content-packages") );
+        } catch (IOException e) {
+            logger.error( "Error Deleting {}, {}", tmpDir + "sub-content-packages", tmpDir + "syntethic-content-packages");
+        }

Review comment:
       @bosschaert this was conflicting for me, I _was_ going to make them constants, but, the existing classes don't have them as constants, and I decided to follow the same practice for consistency sake. Maybe another issue to track making a common constants class across the board? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org