You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "hsheinblatt (via GitHub)" <gi...@apache.org> on 2026/09/03 21:01:41 UTC
[PR] KNOX-3434 - Allow missing typ when validating JWTs from TrustedOidcIssuers for token exchange. [knox]
hsheinblatt opened a new pull request, #1377:
URL: https://github.com/apache/knox/pull/1377
KNOX-3434 - Allow missing typ when validating JWTs from TrustedOidcIssuers for token exchange.
## What changes were proposed in this pull request?
External trusted OIDC issuer tokens do not always have a typ header. In particular,
Kubernetes projected service account tokens do not. Change AbstractJWTFilter
so that RFC 8693 token exchange JWT validations for JWTs from TrustedOidcIssuers
allow a missing typ. This avoids having to dynamically update the list of issuers for which to
skip type verification separately from the trusted OIDC issuer registration, and restricts the
use case to only token exchange for externally trusted issuers.
## How was this patch tested?
A new unit test was added to show that when a JWT is validated for token exchange
and signature validation is to use a registered TrustedOidcIssuer, the typ verifier used
allows a missing typ. There were no typ validation unit tests, so two regression tests
were added to show that for statically defined JWKS validation and for non-token
exchange validation, the existing typ validation continues to be enforced.
## Integration Tests
No integration tests are added in this pull request. They will be added once the full delegation
enforcement flow is wired in a later task.
## UI changes
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-3434 - Allow missing typ when validating JWTs from TrustedOidcIssuers for token exchange. [knox]
Posted by "lmccay (via GitHub)" <gi...@apache.org>.
lmccay merged PR #1377:
URL: https://github.com/apache/knox/pull/1377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-3434 - Allow missing typ when validating JWTs from TrustedOidcIssuers for token exchange. [knox]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1377:
URL: https://github.com/apache/knox/pull/1377#issuecomment-5537066488
## Test Results
4 files 4 suites 16s ⏱️
84 tests 84 ✅ 0 💤 0 ❌
102 runs 102 ✅ 0 💤 0 ❌
Results for commit 1317a738.
[test-results]:data:application/gzip;base64,H4sIANNvmmoC/13MSw6DIBSF4a0Yxh2AF7jazTQokJCqNDxGpnsvGrW0w+8/yVmJdZOJ5N7wW0NidumCzkEl55dCJovLkrat4yceMY/jX3m6Vyn0Cla56SeYEHw4SsjL9shoe+B8rMv3cXd1uLv+G/08u1RAGDBUCJ2VPVocNHCBfSsoBwkDoLWUa26oIO8PehVjKgIBAAA=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org