You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2013/06/15 19:09:47 UTC
[Bug 55102] New: Add ability to report time taken to prepare
response
https://issues.apache.org/bugzilla/show_bug.cgi?id=55102
Bug ID: 55102
Summary: Add ability to report time taken to prepare response
Product: Tomcat 8
Version: trunk
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: jboynes@apache.org
Created attachment 30438
--> https://issues.apache.org/bugzilla/attachment.cgi?id=30438&action=edit
Patch against trunk@r1493385 to record and output time to commit
Tomcat's AccessLogValve is able to report the time taken to send an entire
request using %D. This is the total processing time and may be affected by
network conditions. It is sometimes useful to be able to record the time taken
by the server to prepare the response and send the first content to the client.
Attached is a patch that records the time the response is committed and then
allows that to be reported in the access log using a '%F' pattern (which is the
same as used by the mod-log-firstbyte module for HTTPD).
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 55102] Add ability to report time taken to prepare response
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55102
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from Mark Thomas <ma...@apache.org> ---
Thanks for the patches. They have been applied (with minor modifications) to
trunk and 7.0.x and will be included in 7.0.42 onwards.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 55102] Add ability to report time taken to prepare response
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55102
Jeremy Boynes <jb...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [Bug 55102] New: Add ability to report time taken to prepare
response
Posted by Mark Thomas <ma...@apache.org>.
On 20/06/2013 22:22, Jeremy Boynes wrote:
> On Jun 15, 2013, at 10:09 AM, bugzilla@apache.org wrote:
>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=55102
>> Summary: Add ability to report time taken to prepare response
>>
>> Created attachment 30438
>> --> https://issues.apache.org/bugzilla/attachment.cgi?id=30438&action=edit
>> Patch against trunk@r1493385 to record and output time to commit
>>
>> Tomcat's AccessLogValve is able to report the time taken to send an entire
>> request using %D. This is the total processing time and may be affected by
>> network conditions. It is sometimes useful to be able to record the time taken
>> by the server to prepare the response and send the first content to the client.
>>
>> Attached is a patch that records the time the response is committed and then
>> allows that to be reported in the access log using a '%F' pattern (which is the
>> same as used by the mod-log-firstbyte module for HTTPD).
>
> Any thoughts on this patch? Is it suitable for trunk, and if so should I commit it? Is this something worth back porting to 7.0?
I was just starting to look at this when Konstantin pointed out an
earlier mistake of mine that needed fixing. I'll get back to this shortly.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [Bug 55102] New: Add ability to report time taken to prepare
response
Posted by Rainer Jung <ra...@kippdata.de>.
On 20.06.2013 23:22, Jeremy Boynes wrote:
> On Jun 15, 2013, at 10:09 AM, bugzilla@apache.org wrote:
>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=55102
>> Summary: Add ability to report time taken to prepare response
>>
>> Created attachment 30438
>> --> https://issues.apache.org/bugzilla/attachment.cgi?id=30438&action=edit
>> Patch against trunk@r1493385 to record and output time to commit
>>
>> Tomcat's AccessLogValve is able to report the time taken to send an entire
>> request using %D. This is the total processing time and may be affected by
>> network conditions. It is sometimes useful to be able to record the time taken
>> by the server to prepare the response and send the first content to the client.
>>
>> Attached is a patch that records the time the response is committed and then
>> allows that to be reported in the access log using a '%F' pattern (which is the
>> same as used by the mod-log-firstbyte module for HTTPD).
>
> Any thoughts on this patch? Is it suitable for trunk, and if so should I commit it? Is this something worth back porting to 7.0?
I haven't looked at the concrete patch but the feature sounded useful.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [Bug 55102] New: Add ability to report time taken to prepare response
Posted by Jeremy Boynes <jb...@apache.org>.
On Jun 15, 2013, at 10:09 AM, bugzilla@apache.org wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=55102
> Summary: Add ability to report time taken to prepare response
>
> Created attachment 30438
> --> https://issues.apache.org/bugzilla/attachment.cgi?id=30438&action=edit
> Patch against trunk@r1493385 to record and output time to commit
>
> Tomcat's AccessLogValve is able to report the time taken to send an entire
> request using %D. This is the total processing time and may be affected by
> network conditions. It is sometimes useful to be able to record the time taken
> by the server to prepare the response and send the first content to the client.
>
> Attached is a patch that records the time the response is committed and then
> allows that to be reported in the access log using a '%F' pattern (which is the
> same as used by the mod-log-firstbyte module for HTTPD).
Any thoughts on this patch? Is it suitable for trunk, and if so should I commit it? Is this something worth back porting to 7.0?
Thanks
Jeremy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 55102] Add ability to report time taken to prepare response
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55102
--- Comment #2 from Mark Thomas <ma...@apache.org> ---
Generally the patch looks good to me.
It is missing documentation. Other than that I see no reason not to add it to
trunk and 7.0.x.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 55102] Add ability to report time taken to prepare response
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55102
Jeremy Boynes <jb...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30473|0 |1
is obsolete| |
--- Comment #4 from Jeremy Boynes <jb...@apache.org> ---
Created attachment 30474
--> https://issues.apache.org/bugzilla/attachment.cgi?id=30474&action=edit
Documentation for %F AccessLogValve parameter
Minor change to add username to bug line from previous patch
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 55102] Add ability to report time taken to prepare response
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55102
--- Comment #1 from Jeremy Boynes <jb...@apache.org> ---
Related post on users list:
http://markmail.org/thread/vq3n2igy7q5fttc4
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 55102] Add ability to report time taken to prepare response
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55102
--- Comment #3 from Jeremy Boynes <jb...@apache.org> ---
Created attachment 30473
--> https://issues.apache.org/bugzilla/attachment.cgi?id=30473&action=edit
Documentation for %F AccessLogValve parameter
Add documentation in the docs webapp
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 55102] Add ability to report time taken to prepare response
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55102
--- Comment #5 from Jeremy Boynes <jb...@apache.org> ---
Created attachment 30475
--> https://issues.apache.org/bugzilla/attachment.cgi?id=30475&action=edit
Backport to 7.0.x branch
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org