[GitHub] [spark] JoshRosen commented on a change in pull request #24655: [SPARK-27786] Fix Sha1, Md5, and Base64 codegen when commons-codec is shaded

[GitBox <gi...@apache.org>]

JoshRosen commented on a change in pull request #24655: [SPARK-27786] Fix Sha1, Md5, and Base64 codegen when commons-codec is shaded
URL: https://github.com/apache/spark/pull/24655#discussion_r285861797
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
 ##########
 @@ -24,6 +24,8 @@ import java.util.regex.Pattern
 
 import scala.collection.mutable.ArrayBuffer
 
+import org.apache.commons.codec.binary.{Base64 => CommonsBase64}
 
 Review comment:
   Yep, it conflicts with the expression itself since it's also named `Base64`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org