You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2015/05/19 16:40:51 UTC
Review Request 34410: LENS-550 : Remove enable multi table select
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34410/
-----------------------------------------------------------
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-550
https://issues.apache.org/jira/browse/LENS-550
Repository: lens
Description
-------
Removed CubeQueryConfUtil.ENABLE_MULTI_TABLE_SELECT in relevant places.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 6b6a09b
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java a6374f6
lens-cube/src/main/resources/olap-query-conf.xml b8dbc26
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0f51978
lens-driver-hive/src/main/resources/hivedriver-default.xml 7d06fee
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 841dcac
src/site/apt/admin/hivedriver-config.apt ce0871a
src/site/apt/admin/jdbcdriver-config.apt bdc3d49
src/site/apt/user/olap-query-conf.apt a35c737
Diff: https://reviews.apache.org/r/34410/diff/
Testing
-------
All unit tests are running fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [7.495s]
[INFO] Lens .............................................. SUCCESS [0.402s]
[INFO] Lens API .......................................... SUCCESS [24.028s]
[INFO] Lens API for server and extensions ................ SUCCESS [14.612s]
[INFO] Lens Cube ......................................... SUCCESS [4:22.462s]
[INFO] Lens DB storage ................................... SUCCESS [18.834s]
[INFO] Lens Query Library ................................ SUCCESS [8.753s]
[INFO] Lens Hive Driver .................................. SUCCESS [4:17.572s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [39.551s]
[INFO] Lens Server ....................................... SUCCESS [15:54.537s]
[INFO] Lens client ....................................... SUCCESS [1:04.667s]
[INFO] Lens CLI .......................................... SUCCESS [7:00.657s]
[INFO] Lens Examples ..................................... SUCCESS [3.506s]
[INFO] Lens Distribution ................................. SUCCESS [3.375s]
[INFO] Lens ML Lib ....................................... SUCCESS [3:26.840s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [10.315s]
[INFO] Lens Regression ................................... SUCCESS [1.318s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:20.359s
[INFO] Finished at: Tue May 19 19:49:41 IST 2015
[INFO] Final Memory: 137M/1084M
Thanks,
Sushil Mohanty
Re: Review Request 34410: LENS-550 : Remove enable multi table select
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34410/#review84688
-----------------------------------------------------------
Ship it!
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java
<https://reviews.apache.org/r/34410/#comment136038>
Also, please merge with master and push another patch, this patch is not applying cleanly.
- Rajat Khandelwal
On May 20, 2015, 6:19 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34410/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 6:19 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-550
> https://issues.apache.org/jira/browse/LENS-550
>
>
> Repository: lens
>
>
> Description
> -------
>
> Removed CubeQueryConfUtil.ENABLE_MULTI_TABLE_SELECT in relevant places.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 84e5341
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 6b6a09b
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java a6374f6
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 5d0e15b
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 0704171
> lens-cube/src/main/resources/olap-query-conf.xml b8dbc26
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0f51978
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java 1a31121
> lens-driver-hive/src/main/resources/hivedriver-default.xml 7d06fee
> lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 841dcac
> src/site/apt/admin/hivedriver-config.apt ce0871a
> src/site/apt/admin/jdbcdriver-config.apt bdc3d49
> src/site/apt/user/olap-query-conf.apt a35c737
>
> Diff: https://reviews.apache.org/r/34410/diff/
>
>
> Testing
> -------
>
> All unit tests are running fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [7.495s]
> [INFO] Lens .............................................. SUCCESS [0.402s]
> [INFO] Lens API .......................................... SUCCESS [24.028s]
> [INFO] Lens API for server and extensions ................ SUCCESS [14.612s]
> [INFO] Lens Cube ......................................... SUCCESS [4:22.462s]
> [INFO] Lens DB storage ................................... SUCCESS [18.834s]
> [INFO] Lens Query Library ................................ SUCCESS [8.753s]
> [INFO] Lens Hive Driver .................................. SUCCESS [4:17.572s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.551s]
> [INFO] Lens Server ....................................... SUCCESS [15:54.537s]
> [INFO] Lens client ....................................... SUCCESS [1:04.667s]
> [INFO] Lens CLI .......................................... SUCCESS [7:00.657s]
> [INFO] Lens Examples ..................................... SUCCESS [3.506s]
> [INFO] Lens Distribution ................................. SUCCESS [3.375s]
> [INFO] Lens ML Lib ....................................... SUCCESS [3:26.840s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [10.315s]
> [INFO] Lens Regression ................................... SUCCESS [1.318s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:20.359s
> [INFO] Finished at: Tue May 19 19:49:41 IST 2015
> [INFO] Final Memory: 137M/1084M
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 34410: LENS-550 : Remove enable multi table select
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34410/#review84662
-----------------------------------------------------------
Ship it!
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java
<https://reviews.apache.org/r/34410/#comment136015>
Can you update doc here?
- Amareshwari Sriramadasu
On May 20, 2015, 12:49 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34410/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 12:49 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-550
> https://issues.apache.org/jira/browse/LENS-550
>
>
> Repository: lens
>
>
> Description
> -------
>
> Removed CubeQueryConfUtil.ENABLE_MULTI_TABLE_SELECT in relevant places.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 84e5341
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 6b6a09b
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java a6374f6
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 5d0e15b
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 0704171
> lens-cube/src/main/resources/olap-query-conf.xml b8dbc26
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0f51978
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java 1a31121
> lens-driver-hive/src/main/resources/hivedriver-default.xml 7d06fee
> lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 841dcac
> src/site/apt/admin/hivedriver-config.apt ce0871a
> src/site/apt/admin/jdbcdriver-config.apt bdc3d49
> src/site/apt/user/olap-query-conf.apt a35c737
>
> Diff: https://reviews.apache.org/r/34410/diff/
>
>
> Testing
> -------
>
> All unit tests are running fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [7.495s]
> [INFO] Lens .............................................. SUCCESS [0.402s]
> [INFO] Lens API .......................................... SUCCESS [24.028s]
> [INFO] Lens API for server and extensions ................ SUCCESS [14.612s]
> [INFO] Lens Cube ......................................... SUCCESS [4:22.462s]
> [INFO] Lens DB storage ................................... SUCCESS [18.834s]
> [INFO] Lens Query Library ................................ SUCCESS [8.753s]
> [INFO] Lens Hive Driver .................................. SUCCESS [4:17.572s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.551s]
> [INFO] Lens Server ....................................... SUCCESS [15:54.537s]
> [INFO] Lens client ....................................... SUCCESS [1:04.667s]
> [INFO] Lens CLI .......................................... SUCCESS [7:00.657s]
> [INFO] Lens Examples ..................................... SUCCESS [3.506s]
> [INFO] Lens Distribution ................................. SUCCESS [3.375s]
> [INFO] Lens ML Lib ....................................... SUCCESS [3:26.840s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [10.315s]
> [INFO] Lens Regression ................................... SUCCESS [1.318s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:20.359s
> [INFO] Finished at: Tue May 19 19:49:41 IST 2015
> [INFO] Final Memory: 137M/1084M
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 34410: LENS-550 : Remove enable multi table select
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34410/
-----------------------------------------------------------
(Updated May 21, 2015, 3:52 p.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
Please ignore this previos patch.
Bugs: LENS-550
https://issues.apache.org/jira/browse/LENS-550
Repository: lens
Description
-------
Removed CubeQueryConfUtil.ENABLE_MULTI_TABLE_SELECT in relevant places.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java dab01b3
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java f79e7e7
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java a6374f6
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 2a60310
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 0704171
lens-cube/src/main/resources/olap-query-conf.xml b8dbc26
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0f51978
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java 1a31121
lens-driver-hive/src/main/resources/hivedriver-default.xml 7d06fee
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 841dcac
src/site/apt/admin/hivedriver-config.apt ce0871a
src/site/apt/admin/jdbcdriver-config.apt bdc3d49
src/site/apt/user/olap-query-conf.apt a35c737
Diff: https://reviews.apache.org/r/34410/diff/
Testing
-------
All unit tests are running fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [7.495s]
[INFO] Lens .............................................. SUCCESS [0.402s]
[INFO] Lens API .......................................... SUCCESS [24.028s]
[INFO] Lens API for server and extensions ................ SUCCESS [14.612s]
[INFO] Lens Cube ......................................... SUCCESS [4:22.462s]
[INFO] Lens DB storage ................................... SUCCESS [18.834s]
[INFO] Lens Query Library ................................ SUCCESS [8.753s]
[INFO] Lens Hive Driver .................................. SUCCESS [4:17.572s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [39.551s]
[INFO] Lens Server ....................................... SUCCESS [15:54.537s]
[INFO] Lens client ....................................... SUCCESS [1:04.667s]
[INFO] Lens CLI .......................................... SUCCESS [7:00.657s]
[INFO] Lens Examples ..................................... SUCCESS [3.506s]
[INFO] Lens Distribution ................................. SUCCESS [3.375s]
[INFO] Lens ML Lib ....................................... SUCCESS [3:26.840s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [10.315s]
[INFO] Lens Regression ................................... SUCCESS [1.318s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:20.359s
[INFO] Finished at: Tue May 19 19:49:41 IST 2015
[INFO] Final Memory: 137M/1084M
Thanks,
Sushil Mohanty
Re: Review Request 34410: LENS-550 : Remove enable multi table select
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34410/
-----------------------------------------------------------
(Updated May 21, 2015, 2:01 p.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
Addressed review comment. Attached updated patch to ticket.
Bugs: LENS-550
https://issues.apache.org/jira/browse/LENS-550
Repository: lens
Description
-------
Removed CubeQueryConfUtil.ENABLE_MULTI_TABLE_SELECT in relevant places.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 84e5341
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 6b6a09b
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java a6374f6
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 5d0e15b
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 0704171
lens-cube/src/main/resources/olap-query-conf.xml b8dbc26
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0f51978
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java 1a31121
lens-driver-hive/src/main/resources/hivedriver-default.xml 7d06fee
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 841dcac
src/site/apt/admin/hivedriver-config.apt ce0871a
src/site/apt/admin/jdbcdriver-config.apt bdc3d49
src/site/apt/user/olap-query-conf.apt a35c737
Diff: https://reviews.apache.org/r/34410/diff/
Testing
-------
All unit tests are running fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [7.495s]
[INFO] Lens .............................................. SUCCESS [0.402s]
[INFO] Lens API .......................................... SUCCESS [24.028s]
[INFO] Lens API for server and extensions ................ SUCCESS [14.612s]
[INFO] Lens Cube ......................................... SUCCESS [4:22.462s]
[INFO] Lens DB storage ................................... SUCCESS [18.834s]
[INFO] Lens Query Library ................................ SUCCESS [8.753s]
[INFO] Lens Hive Driver .................................. SUCCESS [4:17.572s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [39.551s]
[INFO] Lens Server ....................................... SUCCESS [15:54.537s]
[INFO] Lens client ....................................... SUCCESS [1:04.667s]
[INFO] Lens CLI .......................................... SUCCESS [7:00.657s]
[INFO] Lens Examples ..................................... SUCCESS [3.506s]
[INFO] Lens Distribution ................................. SUCCESS [3.375s]
[INFO] Lens ML Lib ....................................... SUCCESS [3:26.840s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [10.315s]
[INFO] Lens Regression ................................... SUCCESS [1.318s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:20.359s
[INFO] Finished at: Tue May 19 19:49:41 IST 2015
[INFO] Final Memory: 137M/1084M
Thanks,
Sushil Mohanty
Re: Review Request 34410: LENS-550 : Remove enable multi table select
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34410/
-----------------------------------------------------------
(Updated May 20, 2015, 12:49 p.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
Addressed review comment. All unit tests are running fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [3.920s]
[INFO] Lens .............................................. SUCCESS [0.218s]
[INFO] Lens API .......................................... SUCCESS [15.345s]
[INFO] Lens API for server and extensions ................ SUCCESS [10.676s]
[INFO] Lens Cube ......................................... SUCCESS [4:31.774s]
[INFO] Lens DB storage ................................... SUCCESS [21.503s]
[INFO] Lens Query Library ................................ SUCCESS [13.054s]
[INFO] Lens Hive Driver .................................. SUCCESS [4:50.416s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [1:09.880s]
[INFO] Lens Server ....................................... SUCCESS [20:06.038s]
[INFO] Lens client ....................................... SUCCESS [40.756s]
[INFO] Lens CLI .......................................... SUCCESS [6:53.417s]
[INFO] Lens Examples ..................................... SUCCESS [4.393s]
[INFO] Lens Distribution ................................. SUCCESS [2.545s]
[INFO] Lens ML Lib ....................................... SUCCESS [3:01.734s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [7.408s]
[INFO] Lens Regression ................................... SUCCESS [1.542s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 42:35.748s
[INFO] Finished at: Wed May 20 18:18:27 IST 2015
[INFO] Final Memory: 144M/1329M
[INFO] ------------------------------------------------------------------------
Bugs: LENS-550
https://issues.apache.org/jira/browse/LENS-550
Repository: lens
Description
-------
Removed CubeQueryConfUtil.ENABLE_MULTI_TABLE_SELECT in relevant places.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 84e5341
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 6b6a09b
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java a6374f6
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 5d0e15b
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 0704171
lens-cube/src/main/resources/olap-query-conf.xml b8dbc26
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0f51978
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java 1a31121
lens-driver-hive/src/main/resources/hivedriver-default.xml 7d06fee
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 841dcac
src/site/apt/admin/hivedriver-config.apt ce0871a
src/site/apt/admin/jdbcdriver-config.apt bdc3d49
src/site/apt/user/olap-query-conf.apt a35c737
Diff: https://reviews.apache.org/r/34410/diff/
Testing
-------
All unit tests are running fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [7.495s]
[INFO] Lens .............................................. SUCCESS [0.402s]
[INFO] Lens API .......................................... SUCCESS [24.028s]
[INFO] Lens API for server and extensions ................ SUCCESS [14.612s]
[INFO] Lens Cube ......................................... SUCCESS [4:22.462s]
[INFO] Lens DB storage ................................... SUCCESS [18.834s]
[INFO] Lens Query Library ................................ SUCCESS [8.753s]
[INFO] Lens Hive Driver .................................. SUCCESS [4:17.572s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [39.551s]
[INFO] Lens Server ....................................... SUCCESS [15:54.537s]
[INFO] Lens client ....................................... SUCCESS [1:04.667s]
[INFO] Lens CLI .......................................... SUCCESS [7:00.657s]
[INFO] Lens Examples ..................................... SUCCESS [3.506s]
[INFO] Lens Distribution ................................. SUCCESS [3.375s]
[INFO] Lens ML Lib ....................................... SUCCESS [3:26.840s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [10.315s]
[INFO] Lens Regression ................................... SUCCESS [1.318s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:20.359s
[INFO] Finished at: Tue May 19 19:49:41 IST 2015
[INFO] Final Memory: 137M/1084M
Thanks,
Sushil Mohanty
Re: Review Request 34410: LENS-550 : Remove enable multi table select
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34410/#review84450
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
<https://reviews.apache.org/r/34410/#comment135722>
Remove the boolean flag qlEnabledMultiTableSelect as well.
Do a git grep -i multiTableSelect and make sure there is no code matching.
Similarly git grep -i ENABLE_MULTI_TABLE_SELECT
- Amareshwari Sriramadasu
On May 19, 2015, 2:40 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34410/
> -----------------------------------------------------------
>
> (Updated May 19, 2015, 2:40 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-550
> https://issues.apache.org/jira/browse/LENS-550
>
>
> Repository: lens
>
>
> Description
> -------
>
> Removed CubeQueryConfUtil.ENABLE_MULTI_TABLE_SELECT in relevant places.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 6b6a09b
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java a6374f6
> lens-cube/src/main/resources/olap-query-conf.xml b8dbc26
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0f51978
> lens-driver-hive/src/main/resources/hivedriver-default.xml 7d06fee
> lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 841dcac
> src/site/apt/admin/hivedriver-config.apt ce0871a
> src/site/apt/admin/jdbcdriver-config.apt bdc3d49
> src/site/apt/user/olap-query-conf.apt a35c737
>
> Diff: https://reviews.apache.org/r/34410/diff/
>
>
> Testing
> -------
>
> All unit tests are running fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [7.495s]
> [INFO] Lens .............................................. SUCCESS [0.402s]
> [INFO] Lens API .......................................... SUCCESS [24.028s]
> [INFO] Lens API for server and extensions ................ SUCCESS [14.612s]
> [INFO] Lens Cube ......................................... SUCCESS [4:22.462s]
> [INFO] Lens DB storage ................................... SUCCESS [18.834s]
> [INFO] Lens Query Library ................................ SUCCESS [8.753s]
> [INFO] Lens Hive Driver .................................. SUCCESS [4:17.572s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.551s]
> [INFO] Lens Server ....................................... SUCCESS [15:54.537s]
> [INFO] Lens client ....................................... SUCCESS [1:04.667s]
> [INFO] Lens CLI .......................................... SUCCESS [7:00.657s]
> [INFO] Lens Examples ..................................... SUCCESS [3.506s]
> [INFO] Lens Distribution ................................. SUCCESS [3.375s]
> [INFO] Lens ML Lib ....................................... SUCCESS [3:26.840s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [10.315s]
> [INFO] Lens Regression ................................... SUCCESS [1.318s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:20.359s
> [INFO] Finished at: Tue May 19 19:49:41 IST 2015
> [INFO] Final Memory: 137M/1084M
>
>
> Thanks,
>
> Sushil Mohanty
>
>