You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/25 09:31:02 UTC

[GitHub] [yunikorn-core] HuangTing-Yao opened a new pull request, #491: [YUNIKORN-1438] remove deprecated linters

HuangTing-Yao opened a new pull request, #491:
URL: https://github.com/apache/yunikorn-core/pull/491

   ### What is this PR for?
   Remove deprecated linters
   
   - deadcode 
   - varcheck 
   - structcheck
   
   ### What type of PR is it?
   * [ ] - Bug Fix
   * [ ] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-1438
   
   ### How should this be tested?
   `make lint`
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [yunikorn-core] codecov[bot] commented on pull request #491: [YUNIKORN-1438] remove deprecated linters

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #491:
URL: https://github.com/apache/yunikorn-core/pull/491#issuecomment-1364652611

   # [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/491?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#491](https://codecov.io/gh/apache/yunikorn-core/pull/491?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (12f1cae) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/8bc3720119ff0fa3477816f76fe17778e2ab1d23?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8bc3720) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #491   +/-   ##
   =======================================
     Coverage   73.07%   73.07%           
   =======================================
     Files          69       69           
     Lines       10371    10371           
   =======================================
     Hits         7579     7579           
     Misses       2544     2544           
     Partials      248      248           
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [yunikorn-core] wilfred-s closed pull request #491: [YUNIKORN-1438] remove deprecated linters

Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #491: [YUNIKORN-1438] remove deprecated linters
URL: https://github.com/apache/yunikorn-core/pull/491


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org