You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/02 07:50:31 UTC

[GitHub] [dubbo] jimgreat opened a new issue #8202: 不使用CompletableFuture#get()

jimgreat opened a new issue #8202:
URL: https://github.com/apache/dubbo/issues/8202


   
   
   ### Environment
   
   * Dubbo version: 3.0
   
   AbstractInvoker中有注释 
            /*
                * NOTICE!
                * must call {@link java.util.concurrent.CompletableFuture#get(long, TimeUnit)} because
                * {@link java.util.concurrent.CompletableFuture#get()} was proved to have serious performance drop.
                */
   要使用get(long, TimeUnit)
   
   MergeableClusterInvoker中的
   Result r = asyncResult.get()
   也要改一下吧
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] horizonzy commented on issue #8202: 不使用CompletableFuture#get()

Posted by GitBox <gi...@apache.org>.
horizonzy commented on issue #8202:
URL: https://github.com/apache/dubbo/issues/8202#issuecomment-873438588


   Sure, can you pull request to fix it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] horizonzy commented on issue #8202: 不使用CompletableFuture#get()

Posted by GitBox <gi...@apache.org>.
horizonzy commented on issue #8202:
URL: https://github.com/apache/dubbo/issues/8202#issuecomment-894982883


   fix by #8223


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] horizonzy closed issue #8202: 不使用CompletableFuture#get()

Posted by GitBox <gi...@apache.org>.
horizonzy closed issue #8202:
URL: https://github.com/apache/dubbo/issues/8202


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] MentosL commented on issue #8202: 不使用CompletableFuture#get()

Posted by GitBox <gi...@apache.org>.
MentosL commented on issue #8202:
URL: https://github.com/apache/dubbo/issues/8202#issuecomment-873943708


   > Sure, can you pull request to fix it?
   
   I can fix it and have submitted PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] MentosL commented on issue #8202: 不使用CompletableFuture#get()

Posted by GitBox <gi...@apache.org>.
MentosL commented on issue #8202:
URL: https://github.com/apache/dubbo/issues/8202#issuecomment-873943708


   > Sure, can you pull request to fix it?
   
   I can fix it and have submitted PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org