You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot <re...@mesos.apache.org> on 2019/08/01 01:14:15 UTC
Re: Review Request 71184: Added expected drain end time to webui's
agent screen.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71184/#review217018
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71180, 71181, 71182, 71183, 71184]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 30, 2019, 12:40 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71184/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 12:40 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-9907
> https://issues.apache.org/jira/browse/MESOS-9907
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added expected drain end time to webui's agent screen.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 25d233ba5fd7253e04a7c9cf222f7649bab75baf
> src/webui/app/controllers.js 725230f415b66166543c132a4409d2da303cc1e6
>
>
> Diff: https://reviews.apache.org/r/71184/diff/4/
>
>
> Testing
> -------
>
> * `make check`
> * patched agent to not discard `drainConfig` and inspected screen for `drained` agent run via `mesos-local`
>
>
> Thanks,
>
> Benjamin Bannier
>
>