You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sravya Tirukkovalur <sr...@cloudera.com> on 2014/06/25 03:24:05 UTC
Re: Review Request 22949: SENTRY-313: Fix some uri failing tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22949/
-----------------------------------------------------------
(Updated June 25, 2014, 1:24 a.m.)
Review request for sentry and Prasad Mujumdar.
Summary (updated)
-----------------
SENTRY-313: Fix some uri failing tests
Bugs: sentry-313
https://issues.apache.org/jira/browse/sentry-313
Repository: sentry
Description
-------
Uri locations are reused in the tests causing flakyness, cleaned them up a bit.
- Also making the admin user name and group configurable for tests.
Diffs
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/StaticUserGroup.java d3d8585fde6fcc3196bcf80c8a807e8008a30bb6
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperations.java 22f7dce18d9e3aee0cae4339eec13e18c42272c9
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java 99f3a774847f347c9179fef922f15d56f896913e
Diff: https://reviews.apache.org/r/22949/diff/
Testing
-------
Ran these tests multiple times and everything worked fine.
Thanks,
Sravya Tirukkovalur
Re: Review Request 22949: SENTRY-313: Fix some uri failing tests
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22949/#review46608
-----------------------------------------------------------
Ship it!
Looks fine.
- Prasad Mujumdar
On June 25, 2014, 1:24 a.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22949/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 1:24 a.m.)
>
>
> Review request for sentry and Prasad Mujumdar.
>
>
> Bugs: sentry-313
> https://issues.apache.org/jira/browse/sentry-313
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Uri locations are reused in the tests causing flakyness, cleaned them up a bit.
> - Also making the admin user name and group configurable for tests.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/StaticUserGroup.java d3d8585fde6fcc3196bcf80c8a807e8008a30bb6
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperations.java 22f7dce18d9e3aee0cae4339eec13e18c42272c9
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java 99f3a774847f347c9179fef922f15d56f896913e
>
> Diff: https://reviews.apache.org/r/22949/diff/
>
>
> Testing
> -------
>
> Ran these tests multiple times and everything worked fine.
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>