You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/06/08 15:30:31 UTC

[GitHub] [arrow] westonpace commented on pull request #35980: GH-35979: [C++] Acero - Add basic scalar and group-by window aggregation

westonpace commented on PR #35980:
URL: https://github.com/apache/arrow/pull/35980#issuecomment-1582830154

   @icexelloss happy to meet in person and go over the high level design.  Just from a glance it looks like the aggregate node was split into the scalar and group-by cases with common parts put into aggregate_internal (I'm guessing to help share code between the aggregate cases and the window aggregates).  Then two new window nodes were added.  It seems that both of these nodes rely on the InputReceived being called in a sorted order in the same way that the asof join node does?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org