You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Brian Sanders (JIRA)" <ji...@codehaus.org> on 2010/10/21 12:55:32 UTC

[jira] Created: (ARCHETYPE-339) create-from-project goal should default to using ${package} instead of ${packageInPathFormat}

create-from-project goal should default to using ${package} instead of ${packageInPathFormat}
---------------------------------------------------------------------------------------------

                 Key: ARCHETYPE-339
                 URL: http://jira.codehaus.org/browse/ARCHETYPE-339
             Project: Maven Archetype
          Issue Type: Bug
          Components: Creator
    Affects Versions: 2.0-alpha-5
            Reporter: Brian Sanders
            Priority: Minor
         Attachments: entityProviders.xml, Installer.java

In my particular case, ${packageInPathFormat} is used in all generated files when ${package} should have been. In my XML and java files, ${packageInPathFormat} did not make sense. Maybe there are other cases where it would work. Just seems like ${package} should either be the default, or there should be an option to specify. I attached a few generated files to illustrate the issue.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Closed: (ARCHETYPE-339) create-from-project goal should default to using ${package} instead of ${packageInPathFormat}

Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/ARCHETYPE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Herve Boutemy closed ARCHETYPE-339.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1
         Assignee: Herve Boutemy

unit test added in [r1073564|http://svn.apache.org/viewvc?rev=1073564&view=rev]
fixed in [r1073565|http://svn.apache.org/viewvc?rev=1073565&view=rev]

> create-from-project goal should default to using ${package} instead of ${packageInPathFormat}
> ---------------------------------------------------------------------------------------------
>
>                 Key: ARCHETYPE-339
>                 URL: http://jira.codehaus.org/browse/ARCHETYPE-339
>             Project: Maven Archetype
>          Issue Type: Bug
>          Components: Creator
>    Affects Versions: 2.0-alpha-5
>            Reporter: Brian Sanders
>            Assignee: Herve Boutemy
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: entityProviders.xml, Installer.java
>
>
> In my particular case, ${packageInPathFormat} is used in all generated files when ${package} should have been. In my XML and java files, ${packageInPathFormat} did not make sense. Maybe there are other cases where it would work. Just seems like ${package} should either be the default, or there should be an option to specify. I attached a few generated files to illustrate the issue.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (ARCHETYPE-339) create-from-project goal should default to using ${package} instead of ${packageInPathFormat}

Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/ARCHETYPE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=257126#action_257126 ] 

Herve Boutemy commented on ARCHETYPE-339:
-----------------------------------------

I just hit the same issue, caused by the fact that the initial project had a one-level-only package name
then package == packageInPathFormat, and the archetype creation replaces the packageInPathFormat variable before package
FYI, I just fixed my case by having the sample project in foo.bar package instead of foo: see [r1073199|http://svn.apache.org/viewvc?rev=1073199&view=rev]

BTW, I'll have a look at the code to try to detect this cas and force ${package} instead of ${packageInPathFormat] when their value is the same

> create-from-project goal should default to using ${package} instead of ${packageInPathFormat}
> ---------------------------------------------------------------------------------------------
>
>                 Key: ARCHETYPE-339
>                 URL: http://jira.codehaus.org/browse/ARCHETYPE-339
>             Project: Maven Archetype
>          Issue Type: Bug
>          Components: Creator
>    Affects Versions: 2.0-alpha-5
>            Reporter: Brian Sanders
>            Priority: Minor
>         Attachments: entityProviders.xml, Installer.java
>
>
> In my particular case, ${packageInPathFormat} is used in all generated files when ${package} should have been. In my XML and java files, ${packageInPathFormat} did not make sense. Maybe there are other cases where it would work. Just seems like ${package} should either be the default, or there should be an option to specify. I attached a few generated files to illustrate the issue.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira