You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Ben (JIRA)" <ji...@apache.org> on 2006/10/06 02:35:28 UTC

[jira] Created: (VALIDATOR-204) isValid return false for a valid URL

isValid return false for a valid URL
------------------------------------

                 Key: VALIDATOR-204
                 URL: http://issues.apache.org/jira/browse/VALIDATOR-204
             Project: Commons Validator
          Issue Type: Bug
    Affects Versions: 1.3.0 Release
         Environment: JBOSS, Linux
            Reporter: Ben


IsValid returns false for the following valid Url:

    http://tech.yahoo.com/rc/desktops/102;_ylt=Ao8yevQHlZ4On0O3ZJGXLEQFLZA5

Stepping thru the code isValidPath return false for the above URL.

Test Code:

  String[] schemes = {"http","https"}. 
  UrlValidator urlValidator = new UrlValidator(schemes) ; 
  urlValidator.isValid("http://tech.yahoo.com/rc/desktops/102;_ylt=Ao8yevQHlZ4On0O3ZJGXLEQFLZA5") ;

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (VALIDATOR-204) isValid return false for a valid URL

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/VALIDATOR-204?page=all ]

Henri Yandell updated VALIDATOR-204:
------------------------------------

    Attachment: VALIDATOR-204.patch

This was done as a part of the day-job; so attaching a patch to signify that I passed it from my day-job role to my apache-role.

> isValid return false for a valid URL
> ------------------------------------
>
>                 Key: VALIDATOR-204
>                 URL: http://issues.apache.org/jira/browse/VALIDATOR-204
>             Project: Commons Validator
>          Issue Type: Bug
>    Affects Versions: 1.3.0 Release
>         Environment: JBOSS, Linux
>            Reporter: Ben
>             Fix For: 1.3.1
>
>         Attachments: VALIDATOR-204.patch
>
>
> IsValid returns false for the following valid Url:
>     http://tech.yahoo.com/rc/desktops/102;_ylt=Ao8yevQHlZ4On0O3ZJGXLEQFLZA5
> Stepping thru the code isValidPath return false for the above URL.
> Test Code:
>   String[] schemes = {"http","https"}. 
>   UrlValidator urlValidator = new UrlValidator(schemes) ; 
>   urlValidator.isValid("http://tech.yahoo.com/rc/desktops/102;_ylt=Ao8yevQHlZ4On0O3ZJGXLEQFLZA5") ;

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (VALIDATOR-204) isValid return false for a valid URL

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/VALIDATOR-204?page=comments#action_12440607 ] 
            
Henri Yandell commented on VALIDATOR-204:
-----------------------------------------

The pattern is:

/^(/[-\\w:@&?=+,.!/~*'%$]*)?$/

So the above url fails on the ; and the _. I don't see any reason why they're not being allowed. Looking at the ietf page, it seems to be fine there.

> isValid return false for a valid URL
> ------------------------------------
>
>                 Key: VALIDATOR-204
>                 URL: http://issues.apache.org/jira/browse/VALIDATOR-204
>             Project: Commons Validator
>          Issue Type: Bug
>    Affects Versions: 1.3.0 Release
>         Environment: JBOSS, Linux
>            Reporter: Ben
>
> IsValid returns false for the following valid Url:
>     http://tech.yahoo.com/rc/desktops/102;_ylt=Ao8yevQHlZ4On0O3ZJGXLEQFLZA5
> Stepping thru the code isValidPath return false for the above URL.
> Test Code:
>   String[] schemes = {"http","https"}. 
>   UrlValidator urlValidator = new UrlValidator(schemes) ; 
>   urlValidator.isValid("http://tech.yahoo.com/rc/desktops/102;_ylt=Ao8yevQHlZ4On0O3ZJGXLEQFLZA5") ;

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Resolved: (VALIDATOR-204) isValid return false for a valid URL

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/VALIDATOR-204?page=all ]

Henri Yandell resolved VALIDATOR-204.
-------------------------------------

    Fix Version/s: 1.3.1
       Resolution: Fixed

svn ci -m "Adding _ and ; to the list of allowed characters within the path component of a URL. _ is definitely allowed and ; is allowed but there are restrictions on its use and we'll need to refactor UrlValidator to properly understand how a ; may be used for path parameterization. This is with reference to #VALIDATOR-204." 

Sending        src/share/org/apache/commons/validator/UrlValidator.java
Transmitting file data .
Committed revision 453784.

> isValid return false for a valid URL
> ------------------------------------
>
>                 Key: VALIDATOR-204
>                 URL: http://issues.apache.org/jira/browse/VALIDATOR-204
>             Project: Commons Validator
>          Issue Type: Bug
>    Affects Versions: 1.3.0 Release
>         Environment: JBOSS, Linux
>            Reporter: Ben
>             Fix For: 1.3.1
>
>
> IsValid returns false for the following valid Url:
>     http://tech.yahoo.com/rc/desktops/102;_ylt=Ao8yevQHlZ4On0O3ZJGXLEQFLZA5
> Stepping thru the code isValidPath return false for the above URL.
> Test Code:
>   String[] schemes = {"http","https"}. 
>   UrlValidator urlValidator = new UrlValidator(schemes) ; 
>   urlValidator.isValid("http://tech.yahoo.com/rc/desktops/102;_ylt=Ao8yevQHlZ4On0O3ZJGXLEQFLZA5") ;

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org