You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2025/02/10 12:18:49 UTC
[PR] fix(string): the server will be crashed when passing a negative offset in SETRANGE command [kvrocks]
git-hulk opened a new pull request, #2783:
URL: https://github.com/apache/kvrocks/pull/2783
Currently, we didn't check if the offset is a negative value and using it to index the value string will crash the server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(string): the server will be crashed when passing a negative offset in SETRANGE command [kvrocks]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2783:
URL: https://github.com/apache/kvrocks/pull/2783#issuecomment-2648407397
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2783) **Quality Gate failed**
Failed conditions
 [47 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=2783&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2783)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(string): the server will be crashed when passing a negative offset in SETRANGE command [kvrocks]
Posted by "torwig (via GitHub)" <gi...@apache.org>.
torwig commented on code in PR #2783:
URL: https://github.com/apache/kvrocks/pull/2783#discussion_r1949059618
##########
src/cli/main.cc:
##########
@@ -109,7 +109,6 @@ static void InitGoogleLog(const Config *config) {
} else {
FLAGS_log_dir = config->log_dir + "/";
if (config->log_retention_days != -1) {
- google::EnableLogCleaner(std::chrono::hours(24) * config->log_retention_days);
Review Comment:
We don't need this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(string): the server will be crashed when passing a negative offset in SETRANGE command [kvrocks]
Posted by "torwig (via GitHub)" <gi...@apache.org>.
torwig commented on code in PR #2783:
URL: https://github.com/apache/kvrocks/pull/2783#discussion_r1949059618
##########
src/cli/main.cc:
##########
@@ -109,7 +109,6 @@ static void InitGoogleLog(const Config *config) {
} else {
FLAGS_log_dir = config->log_dir + "/";
if (config->log_retention_days != -1) {
- google::EnableLogCleaner(std::chrono::hours(24) * config->log_retention_days);
Review Comment:
We don't need a thin line?
##########
src/cli/main.cc:
##########
@@ -109,7 +109,6 @@ static void InitGoogleLog(const Config *config) {
} else {
FLAGS_log_dir = config->log_dir + "/";
if (config->log_retention_days != -1) {
- google::EnableLogCleaner(std::chrono::hours(24) * config->log_retention_days);
Review Comment:
We don't need a this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(string): the server will be crashed when passing a negative offset in SETRANGE command [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on code in PR #2783:
URL: https://github.com/apache/kvrocks/pull/2783#discussion_r1949067988
##########
src/cli/main.cc:
##########
@@ -109,7 +109,6 @@ static void InitGoogleLog(const Config *config) {
} else {
FLAGS_log_dir = config->log_dir + "/";
if (config->log_retention_days != -1) {
- google::EnableLogCleaner(std::chrono::hours(24) * config->log_retention_days);
Review Comment:
Yes, I forget to revert this change. This line throws an error on my macOS when building. I workaround this by remove it temporially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(string): the server will be crashed when passing a negative offset in SETRANGE command [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk merged PR #2783:
URL: https://github.com/apache/kvrocks/pull/2783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org