[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3349: improves fetching mulitple extents in ample

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on code in PR #3349:
URL: https://github.com/apache/accumulo/pull/3349#discussion_r1181917744


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServer.java:
##########
@@ -149,8 +149,8 @@ private TabletMetadataLoader(Ample ample) {
         loadAll(Set<? extends KeyExtent> keys) {
       long t1 = System.currentTimeMillis();
       @SuppressWarnings("unchecked")
-      var tms = ample.readTablets().forTablets((Collection<KeyExtent>) keys).build().stream()
-          .collect(Collectors.toMap(tm -> tm.getExtent(), tm -> tm));
+      var tms = ample.readTablets().forTablets((Collection<KeyExtent>) keys, e -> {}).build()

Review Comment:
   Seems like we use a NOOP consumer in a few places. Might be useful to assign that to a variable like `ignoreNotFound`



##########
server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/CompactionFinalizer.java:
##########
@@ -155,7 +155,7 @@ private void processPending() {
 
         Map<KeyExtent,TabletMetadata> tabletsMetadata;
         var extents = batch.stream().map(ExternalCompactionFinalState::getExtent).collect(toList());
-        try (TabletsMetadata tablets = context.getAmple().readTablets().forTablets(extents)
+        try (TabletsMetadata tablets = context.getAmple().readTablets().forTablets(extents, e -> {})

Review Comment:
   What's going on with this NOOP consumer?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org