You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "XieJiann (via GitHub)" <gi...@apache.org> on 2024/07/24 03:03:26 UTC
[PR] [opt](Nereids): fix comment and remove useless code [doris]
XieJiann opened a new pull request, #38282:
URL: https://github.com/apache/doris/pull/38282
## Proposed changes
1. fix comment in eliminate func deps
2. remove computeFdItem codes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](Nereids): fix comment and remove useless function `computeFdItem ` [doris]
Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann commented on PR #38282:
URL: https://github.com/apache/doris/pull/38282#issuecomment-2246772273
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](Nereids): fix comment and remove useless code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38282:
URL: https://github.com/apache/doris/pull/38282#issuecomment-2246771890
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](Nereids): fix comment and remove useless function `computeFdItem ` [doris]
Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann merged PR #38282:
URL: https://github.com/apache/doris/pull/38282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](Nereids): fix comment and remove useless function `computeFdItem ` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38282:
URL: https://github.com/apache/doris/pull/38282#issuecomment-2246795556
<details>
<summary>TPC-DS: <b>Total hot run time: 173770 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit eb1fdc5058c5da85e47329b71b6d4c29deea2fd0, data reload: false
query1 922 379 369 369
query2 6453 1962 1894 1894
query3 6655 209 215 209
query4 27811 17721 17443 17443
query5 4176 490 482 482
query6 284 174 161 161
query7 4596 291 288 288
query8 245 191 189 189
query9 8397 2412 2391 2391
query10 445 283 284 283
query11 10600 10037 10062 10037
query12 140 93 84 84
query13 1649 374 370 370
query14 10158 7888 7861 7861
query15 214 165 167 165
query16 7540 482 464 464
query17 1309 569 521 521
query18 1531 275 282 275
query19 194 166 145 145
query20 87 85 78 78
query21 203 129 130 129
query22 4350 4126 4064 4064
query23 33576 33096 33001 33001
query24 12252 2921 2873 2873
query25 654 380 393 380
query26 1717 148 152 148
query27 2845 283 275 275
query28 7493 2006 1991 1991
query29 1048 634 629 629
query30 285 148 149 148
query31 951 724 750 724
query32 94 52 52 52
query33 774 334 328 328
query34 878 478 486 478
query35 854 776 735 735
query36 1109 949 949 949
query37 274 78 81 78
query38 2868 2784 2756 2756
query39 864 808 788 788
query40 276 119 123 119
query41 75 48 44 44
query42 117 101 107 101
query43 515 481 456 456
query44 1173 737 736 736
query45 189 166 160 160
query46 1097 736 734 734
query47 1861 1768 1793 1768
query48 370 291 300 291
query49 1184 423 416 416
query50 805 392 401 392
query51 6822 6709 6746 6709
query52 105 90 95 90
query53 365 291 285 285
query54 1091 452 452 452
query55 75 76 75 75
query56 299 274 292 274
query57 1160 1056 1032 1032
query58 260 247 262 247
query59 2891 2869 2669 2669
query60 297 287 331 287
query61 97 93 95 93
query62 828 653 654 653
query63 327 308 293 293
query64 10543 2192 1666 1666
query65 3147 3108 3129 3108
query66 1296 346 331 331
query67 15541 15325 15031 15031
query68 4543 553 549 549
query69 442 349 338 338
query70 1172 1138 1053 1053
query71 406 284 308 284
query72 6986 6012 5539 5539
query73 748 330 331 330
query74 6067 5699 5689 5689
query75 3412 2679 2648 2648
query76 2825 881 904 881
query77 474 302 308 302
query78 9473 9057 8999 8999
query79 2683 526 529 526
query80 2345 476 470 470
query81 585 220 219 219
query82 937 135 148 135
query83 301 171 168 168
query84 273 94 85 85
query85 1420 313 351 313
query86 466 311 340 311
query87 3298 3150 3164 3150
query88 4402 2376 2396 2376
query89 484 386 398 386
query90 1809 209 205 205
query91 146 120 111 111
query92 75 50 51 50
query93 1967 524 520 520
query94 1264 309 304 304
query95 411 338 328 328
query96 626 284 273 273
query97 3199 3010 3015 3010
query98 216 207 202 202
query99 1457 1300 1269 1269
Total cold run time: 284213 ms
Total hot run time: 173770 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](Nereids): fix comment and remove useless function `computeFdItem ` [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38282:
URL: https://github.com/apache/doris/pull/38282#issuecomment-2246778090
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](Nereids): fix comment and remove useless function `computeFdItem ` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38282:
URL: https://github.com/apache/doris/pull/38282#issuecomment-2246786612
<details>
<summary>TPC-H: <b>Total hot run time: 39750 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit eb1fdc5058c5da85e47329b71b6d4c29deea2fd0, data reload: false
------ Round 1 ----------------------------------
q1 18091 4445 4358 4358
q2 2261 189 184 184
q3 10472 1176 1109 1109
q4 10187 816 825 816
q5 7548 2664 2680 2664
q6 219 136 141 136
q7 954 601 615 601
q8 9215 2053 2066 2053
q9 8646 6548 6524 6524
q10 8821 3780 3805 3780
q11 453 239 243 239
q12 396 229 228 228
q13 18887 2979 2996 2979
q14 272 242 243 242
q15 535 482 500 482
q16 487 388 375 375
q17 953 606 689 606
q18 8068 7661 7382 7382
q19 8370 1205 1256 1205
q20 667 319 327 319
q21 4905 3196 3188 3188
q22 344 287 280 280
Total cold run time: 120751 ms
Total hot run time: 39750 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4414 4278 4340 4278
q2 374 279 267 267
q3 3014 2771 2758 2758
q4 1930 1658 1665 1658
q5 5271 5361 5294 5294
q6 218 132 135 132
q7 2146 1755 1703 1703
q8 3203 3339 3320 3320
q9 8426 8360 8421 8360
q10 3947 3674 3688 3674
q11 596 501 508 501
q12 768 625 629 625
q13 17384 2997 2975 2975
q14 306 280 274 274
q15 525 479 471 471
q16 477 433 432 432
q17 1762 1493 1471 1471
q18 7810 7532 7523 7523
q19 1664 1604 1577 1577
q20 2017 1819 1793 1793
q21 4871 4707 4673 4673
q22 583 480 525 480
Total cold run time: 71706 ms
Total hot run time: 54239 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](Nereids): fix comment and remove useless function `computeFdItem ` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38282:
URL: https://github.com/apache/doris/pull/38282#issuecomment-2246800089
<details>
<summary>ClickBench: <b>Total hot run time: 30.87 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit eb1fdc5058c5da85e47329b71b6d4c29deea2fd0, data reload: false
query1 0.05 0.03 0.03
query2 0.08 0.04 0.04
query3 0.22 0.06 0.05
query4 1.68 0.07 0.07
query5 0.49 0.48 0.47
query6 1.14 0.72 0.72
query7 0.02 0.02 0.02
query8 0.05 0.04 0.05
query9 0.54 0.47 0.50
query10 0.56 0.53 0.55
query11 0.16 0.11 0.11
query12 0.15 0.12 0.12
query13 0.59 0.60 0.58
query14 0.76 0.78 0.77
query15 0.87 0.82 0.82
query16 0.36 0.37 0.38
query17 1.00 0.99 0.96
query18 0.22 0.22 0.21
query19 1.92 1.73 1.79
query20 0.01 0.01 0.01
query21 15.46 0.76 0.66
query22 4.00 7.63 2.10
query23 18.32 1.41 1.30
query24 2.17 0.23 0.22
query25 0.16 0.08 0.08
query26 0.30 0.21 0.21
query27 0.46 0.23 0.23
query28 13.21 1.03 1.00
query29 12.60 3.35 3.30
query30 0.25 0.06 0.06
query31 2.88 0.39 0.41
query32 3.23 0.48 0.47
query33 2.87 2.90 2.93
query34 17.08 4.40 4.37
query35 4.44 4.46 4.41
query36 0.65 0.47 0.48
query37 0.20 0.16 0.15
query38 0.16 0.15 0.15
query39 0.04 0.03 0.04
query40 0.16 0.12 0.12
query41 0.09 0.05 0.04
query42 0.06 0.05 0.05
query43 0.05 0.04 0.04
Total cold run time: 109.71 s
Total hot run time: 30.87 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](Nereids): fix comment and remove useless function `computeFdItem ` [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38282:
URL: https://github.com/apache/doris/pull/38282#issuecomment-2246778057
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org