You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/16 15:18:42 UTC
[GitHub] [spark] RabbidHY opened a new pull request #34022: [SPARK-36780][BUILD] make dev/mima runs on Java 17
RabbidHY opened a new pull request #34022:
URL: https://github.com/apache/spark/pull/34022
### What changes were proposed in this pull request?
Java 17 has been officially released. This PR makes `dev/mima` runs on Java 17.
### Why are the changes needed?
To make tests pass on Java 17.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921901621
Thank you for updating again, @RabbidHY . I fixed a typo at the last commit. It was due to my comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-920996676
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34022: [SPARK-36780][BUILD] make dev/mima runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-920996676
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921905829
**[Test build #143417 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143417/testReport)** for PR 34022 at commit [`4dadb6f`](https://github.com/apache/spark/commit/4dadb6f0ebabcee5db30ecd2b969d5a6b576cd44).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921082022
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47863/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921054533
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47860/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921950050
**[Test build #143415 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143415/testReport)** for PR 34022 at commit [`d22d8ef`](https://github.com/apache/spark/commit/d22d8efd5109adab6ed738316c05b6f2435c41e0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921906213
Welcome to the Apache Spark community, @RabbidHY .
You are added to the Apache Spark contributor group and SPARK-36780 is assigned to you. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921839790
**[Test build #143415 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143415/testReport)** for PR 34022 at commit [`d22d8ef`](https://github.com/apache/spark/commit/d22d8efd5109adab6ed738316c05b6f2435c41e0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921899498
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47922/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34022:
URL: https://github.com/apache/spark/pull/34022#discussion_r710236231
##########
File path: dev/mima
##########
@@ -41,6 +41,12 @@ else
JAVA_CMD=java
fi
+# Workaround to make mima runs on Java 17+
+JAVA_VER=$(java -version 2>&1 | head -1 | cut -d'"' -f2 | sed '/^1\./s///' | cut -d'.' -f1)
+if [[ JAVA_VER -ge 17 ]]; then
Review comment:
Could you extend this for Java 11, too? `-ge 11` instead of `-ge 17`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34022:
URL: https://github.com/apache/spark/pull/34022#discussion_r710236231
##########
File path: dev/mima
##########
@@ -41,6 +41,12 @@ else
JAVA_CMD=java
fi
+# Workaround to make mima runs on Java 17+
+JAVA_VER=$(java -version 2>&1 | head -1 | cut -d'"' -f2 | sed '/^1\./s///' | cut -d'.' -f1)
+if [[ JAVA_VER -ge 17 ]]; then
Review comment:
Could you extend this for Java 11, too? `-ge 11` instead of `-ge 17`?
Then, it will remove the following warning at Java 11 additionally.
```
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by scala.reflect.package$ (file:/Users/dongjoon/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/org/scala-lang/scala-library/2.12.15/scala-library-2.12.15.jar) to method java.util.jar.JarFile$JarFileEntry.getName()
WARNING: Please consider reporting this to the maintainers of scala.reflect.package$
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921039531
**[Test build #143356 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143356/testReport)** for PR 34022 at commit [`13ccf81`](https://github.com/apache/spark/commit/13ccf81b8cdc28636fe37da5cb26507201edc2cc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921910419
**[Test build #143417 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143417/testReport)** for PR 34022 at commit [`4dadb6f`](https://github.com/apache/spark/commit/4dadb6f0ebabcee5db30ecd2b969d5a6b576cd44).
* This patch **fails to build**.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921024501
**[Test build #143354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143354/testReport)** for PR 34022 at commit [`c7833d5`](https://github.com/apache/spark/commit/c7833d5e68bd3d11d90108d7c978498bdff1ec2a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921151233
**[Test build #143354 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143354/testReport)** for PR 34022 at commit [`c7833d5`](https://github.com/apache/spark/commit/c7833d5e68bd3d11d90108d7c978498bdff1ec2a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921156226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921951189
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143415/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921939196
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47924/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921951189
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143415/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34022:
URL: https://github.com/apache/spark/pull/34022#discussion_r710281585
##########
File path: dev/mima
##########
@@ -41,8 +41,16 @@ else
JAVA_CMD=java
fi
+
+# Workaround to make mima runs on Java 11+
+JAVA_VER=$(java -version 2>&1 | head -1 | cut -d'"' -f2 | sed '/^1\./s///' | cut -d'.' -f1)
+if [[ JAVA_VER -ge 11 ]]; then
+ EXTRA_JAVA_OPTIONS="--add-opens=java.base/java.util.jar=ALL-UNNAMED"
+fi
+
$JAVA_CMD \
-Xmx2g \
+ $EXTRA_JAVA_OPTIONS \
Review comment:
Thank you for update. Let's simplify like this by removing line 44~50 and add directly.
```
$JAVA_CMD \
-Xmx2g \
-XX:+IgnoreUnrecognizedVMOptions --add-opens=java.base/java.util.jar=ALL-UNNAME \
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921940725
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47924/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] RabbidHY commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
RabbidHY commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921944638
> Welcome to the Apache Spark community, @RabbidHY .
> You are added to the Apache Spark contributor group and [SPARK-36780](https://issues.apache.org/jira/browse/SPARK-36780) is assigned to you. :)
Thank you very much Dongjoon! :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921150574
**[Test build #143356 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143356/testReport)** for PR 34022 at commit [`13ccf81`](https://github.com/apache/spark/commit/13ccf81b8cdc28636fe37da5cb26507201edc2cc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921156226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921075006
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47863/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921910482
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143417/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921893258
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47922/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921934429
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47924/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #34022:
URL: https://github.com/apache/spark/pull/34022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921502180
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921065949
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47860/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921082022
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47863/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921910482
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143417/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921060846
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47860/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34022: [SPARK-36780][BUILD] make dev/mima runs on Java 17
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921007232
Thank you, @RabbidHY .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #34022: [SPARK-36780][BUILD] make dev/mima runs on Java 17
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921004504
ok to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921502180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921940725
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47924/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921081946
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47863/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921839790
**[Test build #143415 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143415/testReport)** for PR 34022 at commit [`d22d8ef`](https://github.com/apache/spark/commit/d22d8efd5109adab6ed738316c05b6f2435c41e0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921065949
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47860/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921902463
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47922/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921039531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34022: [SPARK-36780][BUILD] Make `dev/mima` runs on Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34022:
URL: https://github.com/apache/spark/pull/34022#issuecomment-921905829
**[Test build #143417 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143417/testReport)** for PR 34022 at commit [`4dadb6f`](https://github.com/apache/spark/commit/4dadb6f0ebabcee5db30ecd2b969d5a6b576cd44).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org