You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/16 05:36:25 UTC
[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1562: Remove protocol from EmailConfiguration and use SMTP as default protocol
TeslaCN opened a new pull request #1562:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1562
Fixes #1561
Changes proposed in this pull request:
- Remove 'protocol' from EmailConfiguration.
- Set 'smtp' as default protocol of email error handler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1562: Remove protocol from EmailConfiguration and use SMTP as default protocol
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1562:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1562#issuecomment-709810293
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562?src=pr&el=h1) Report
> Merging [#1562](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/67bafbe644b63fc38a272c67fa46769a693b7438?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1562 +/- ##
============================================
- Coverage 85.26% 85.26% -0.01%
Complexity 103 103
============================================
Files 250 250
Lines 5689 5688 -1
Branches 882 882
============================================
- Hits 4851 4850 -1
Misses 523 523
Partials 315 315
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ticjob/error/handler/email/EmailConfiguration.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1lbWFpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9lcnJvci9oYW5kbGVyL2VtYWlsL0VtYWlsQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...elasticjob/error/handler/email/EmailConstants.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1lbWFpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9lcnJvci9oYW5kbGVyL2VtYWlsL0VtYWlsQ29uc3RhbnRzLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...cjob/error/handler/email/EmailJobErrorHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1lbWFpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9lcnJvci9oYW5kbGVyL2VtYWlsL0VtYWlsSm9iRXJyb3JIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562?src=pr&el=footer). Last update [67bafbe...9fa30d2](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- merged pull request #1562: Remove protocol from EmailConfiguration and use SMTP as default protocol
Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1562:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1562
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1562: Remove protocol from EmailConfiguration and use SMTP as default protocol
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1562:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1562#issuecomment-709810293
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562?src=pr&el=h1) Report
> Merging [#1562](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/67bafbe644b63fc38a272c67fa46769a693b7438?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1562 +/- ##
============================================
- Coverage 85.26% 85.26% -0.01%
Complexity 103 103
============================================
Files 250 250
Lines 5689 5688 -1
Branches 882 882
============================================
- Hits 4851 4850 -1
Misses 523 523
Partials 315 315
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ticjob/error/handler/email/EmailConfiguration.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1lbWFpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9lcnJvci9oYW5kbGVyL2VtYWlsL0VtYWlsQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...elasticjob/error/handler/email/EmailConstants.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1lbWFpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9lcnJvci9oYW5kbGVyL2VtYWlsL0VtYWlsQ29uc3RhbnRzLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...cjob/error/handler/email/EmailJobErrorHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1lbWFpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9lcnJvci9oYW5kbGVyL2VtYWlsL0VtYWlsSm9iRXJyb3JIYW5kbGVyLmphdmE=) | `81.81% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562?src=pr&el=footer). Last update [67bafbe...9fa30d2](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1562?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org