[GitHub] spark pull request #14038: [SPARK-16317][SQL] Add a new interface to filter ...

[steveloughran <gi...@git.apache.org>]

Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14038#discussion_r89839965
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala ---
    @@ -441,6 +441,44 @@ class FileSourceStrategySuite extends QueryTest with SharedSQLContext with Predi
         }
       }
     
    +  test("filter out invalid files in a driver") {
    +    withSQLConf(
    +      "fs.file.impl" -> classOf[MockDistributedFileSystem].getName,
    +      SQLConf.PARALLEL_PARTITION_DISCOVERY_THRESHOLD.key -> "3") {
    +      val table =
    +        createTable(
    +          files = Seq(
    +            "p1=1/file1" -> 1,
    +            "p1=1/file2" -> 1,
    +            "p1=2/file3" -> 1,
    +            "p1=2/invalid_file" -> 1))
    --- End diff --
    
    I'd consider adding the full set of invalid files:
    ```
    p1=2/file=3 -> 1
    p1=2/.temp -> 1
    
    ```
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org