You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2008/11/15 18:27:44 UTC

[jira] Created: (SOLR-863) SolrCore.initIndex should close the directory it gets for clearing the lock and use the DirectoryFactory

SolrCore.initIndex should close the directory it gets for clearing the lock and use the DirectoryFactory
--------------------------------------------------------------------------------------------------------

                 Key: SOLR-863
                 URL: https://issues.apache.org/jira/browse/SOLR-863
             Project: Solr
          Issue Type: Bug
            Reporter: Mark Miller
            Priority: Trivial
             Fix For: 1.3.1


Could put the close in a finally as well, but if you get an exception here I don't think your going anywhere anyway, so probably doesn't matter (it probably doesn't even matter that its not closed, but it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SOLR-863) SolrCore.initIndex should close the directory it gets for clearing the lock and use the DirectoryFactory

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar updated SOLR-863:
---------------------------------------

    Attachment: SOLR-863.patch

Made sure we don't call close on a null dir. I plan to commit shortly.

> SolrCore.initIndex should close the directory it gets for clearing the lock and use the DirectoryFactory
> --------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-863
>                 URL: https://issues.apache.org/jira/browse/SOLR-863
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Priority: Trivial
>             Fix For: 1.3.1
>
>         Attachments: SOLR-863.patch, SOLR-863.patch
>
>
> Could put the close in a finally as well, but if you get an exception here I don't think your going anywhere anyway, so probably doesn't matter (it probably doesn't even matter that its not closed, but it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (SOLR-863) SolrCore.initIndex should close the directory it gets for clearing the lock and use the DirectoryFactory

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar resolved SOLR-863.
----------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.3.1)
                   1.4
         Assignee: Shalin Shekhar Mangar

Committed revision 727719.

Thanks Mark!

> SolrCore.initIndex should close the directory it gets for clearing the lock and use the DirectoryFactory
> --------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-863
>                 URL: https://issues.apache.org/jira/browse/SOLR-863
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Shalin Shekhar Mangar
>            Priority: Trivial
>             Fix For: 1.4
>
>         Attachments: SOLR-863.patch, SOLR-863.patch
>
>
> Could put the close in a finally as well, but if you get an exception here I don't think your going anywhere anyway, so probably doesn't matter (it probably doesn't even matter that its not closed, but it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SOLR-863) SolrCore.initIndex should close the directory it gets for clearing the lock and use the DirectoryFactory

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller updated SOLR-863:
-----------------------------

    Attachment: SOLR-863.patch

> SolrCore.initIndex should close the directory it gets for clearing the lock and use the DirectoryFactory
> --------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-863
>                 URL: https://issues.apache.org/jira/browse/SOLR-863
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Priority: Trivial
>             Fix For: 1.3.1
>
>         Attachments: SOLR-863.patch
>
>
> Could put the close in a finally as well, but if you get an exception here I don't think your going anywhere anyway, so probably doesn't matter (it probably doesn't even matter that its not closed, but it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.