You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2026/05/29 10:22:51 UTC

[L] Change in asterixdb[lumina]: [ASTERIXDB-3778][COMP] Drop constant ORDER BY sort keys

From Rithwik Koul <ri...@couchbase.com>:

Attention is currently required from: Ali Alsuliman, Preetham Poluparthi.

Hello Ali Alsuliman, Anon. E. Moose #1000171, Jenkins, Preetham Poluparthi, 

I'd like you to reexamine a change. Please visit

    https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21290?usp=email

to look at the new patch set (#11).


Change subject: [ASTERIXDB-3778][COMP] Drop constant ORDER BY sort keys
......................................................................

[ASTERIXDB-3778][COMP] Drop constant ORDER BY sort keys

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Adds RemoveConstantOrderByExpressionsRule, which strips entries from
OrderOperator.getOrderExpressions() whose value is a compile-time
constant. The OrderOperator is unwrapped entirely if every key
becomes constant.

Ext-ref: MB-72146
Change-Id: I1156355d55b0f4cdde0044fb94e9c1b3ed15a3f2
---
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveConstantOrderByExpressionsRule.java
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/group-by/grouping-sets-empty-branch.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/order-by/order-by-const-folded.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/order-by/order-by-const-mixed.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/order-by/order-by-const-single.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/order-by/order-by-real-var.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/group-by/grouping-sets-empty-branch.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/order-by/order-by-const-folded.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/order-by/order-by-const-mixed.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/order-by/order-by-const-single.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/order-by/order-by-real-var.plan
12 files changed, 443 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/90/21290/11
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21290?usp=email
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: lumina
Gerrit-Change-Id: I1156355d55b0f4cdde0044fb94e9c1b3ed15a3f2
Gerrit-Change-Number: 21290
Gerrit-PatchSet: 11
Gerrit-Owner: Rithwik Koul <ri...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@couchbase.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preetham Poluparthi <pr...@apache.org>
Gerrit-Reviewer: Rithwik Koul <ri...@couchbase.com>
Gerrit-CC: Murtadha Hubail <mh...@apache.org>
Gerrit-Attention: Ali Alsuliman <al...@couchbase.com>
Gerrit-Attention: Preetham Poluparthi <pr...@apache.org>