You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Artemy Tregubenko (JIRA)" <ji...@apache.org> on 2008/08/19 17:53:45 UTC
[jira] Created: (SHINDIG-528) Fix crypto in unicode environment
Fix crypto in unicode environment
---------------------------------
Key: SHINDIG-528
URL: https://issues.apache.org/jira/browse/SHINDIG-528
Project: Shindig
Issue Type: Improvement
Components: Common Components (PHP)
Environment: PHP uses mbstring.func_overload set to 7
Reporter: Artemy Tregubenko
Priority: Minor
Attachments: unicode_crypto_patch.diff
This PHP setting automagically makes many string functions to work in unicode-compatible mode. However it's not very good when strings are used as byte arrays. Currently BasicBlobCrypter and Crypto classes do this, and thus are not compatible with this option. Attached patch fixes this.
Also there're 2 more small fixes: protected, not private access for overridable config variables, removal of require of Crypto in BasicBlobCrypter, as it's autoloadable but may be not available at given path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-528) Fix crypto in unicode environment
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625066#action_12625066 ]
Artemy Tregubenko commented on SHINDIG-528:
-------------------------------------------
No, however we don't have full-featured installation yet. I believe there won't be more, as problems are usually in byte-arrays and regular expressions on non-ascii strings (preg_*). Looks like byte-arrays are fixed now and I didn't see many regexes in code.
> Fix crypto in unicode environment
> ---------------------------------
>
> Key: SHINDIG-528
> URL: https://issues.apache.org/jira/browse/SHINDIG-528
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Environment: PHP uses mbstring.func_overload set to 7
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
> Attachments: unicode_crypto_patch.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This PHP setting automagically makes many string functions to work in unicode-compatible mode. However it's not very good when strings are used as byte arrays. Currently BasicBlobCrypter and Crypto classes do this, and thus are not compatible with this option. Attached patch fixes this.
> Also there're 2 more small fixes: protected, not private access for overridable config variables, removal of require of Crypto in BasicBlobCrypter, as it's autoloadable but may be not available at given path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-528) Fix crypto in unicode environment
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625070#action_12625070 ]
Artemy Tregubenko commented on SHINDIG-528:
-------------------------------------------
Nice, thanks! Hope you'll also remove that nasty 'require' and change private access to configurable properties to protected : )
> Fix crypto in unicode environment
> ---------------------------------
>
> Key: SHINDIG-528
> URL: https://issues.apache.org/jira/browse/SHINDIG-528
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Environment: PHP uses mbstring.func_overload set to 7
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
> Attachments: unicode_crypto_patch.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This PHP setting automagically makes many string functions to work in unicode-compatible mode. However it's not very good when strings are used as byte arrays. Currently BasicBlobCrypter and Crypto classes do this, and thus are not compatible with this option. Attached patch fixes this.
> Also there're 2 more small fixes: protected, not private access for overridable config variables, removal of require of Crypto in BasicBlobCrypter, as it's autoloadable but may be not available at given path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-528) Fix crypto in unicode environment
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Artemy Tregubenko closed SHINDIG-528.
-------------------------------------
> Fix crypto in unicode environment
> ---------------------------------
>
> Key: SHINDIG-528
> URL: https://issues.apache.org/jira/browse/SHINDIG-528
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Environment: PHP uses mbstring.func_overload set to 7
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
> Attachments: unicode_crypto_patch.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This PHP setting automagically makes many string functions to work in unicode-compatible mode. However it's not very good when strings are used as byte arrays. Currently BasicBlobCrypter and Crypto classes do this, and thus are not compatible with this option. Attached patch fixes this.
> Also there're 2 more small fixes: protected, not private access for overridable config variables, removal of require of Crypto in BasicBlobCrypter, as it's autoloadable but may be not available at given path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-528) Fix crypto in unicode environment
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Artemy Tregubenko updated SHINDIG-528:
--------------------------------------
Attachment: unicode_crypto_patch.diff
> Fix crypto in unicode environment
> ---------------------------------
>
> Key: SHINDIG-528
> URL: https://issues.apache.org/jira/browse/SHINDIG-528
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Environment: PHP uses mbstring.func_overload set to 7
> Reporter: Artemy Tregubenko
> Priority: Minor
> Attachments: unicode_crypto_patch.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This PHP setting automagically makes many string functions to work in unicode-compatible mode. However it's not very good when strings are used as byte arrays. Currently BasicBlobCrypter and Crypto classes do this, and thus are not compatible with this option. Attached patch fixes this.
> Also there're 2 more small fixes: protected, not private access for overridable config variables, removal of require of Crypto in BasicBlobCrypter, as it's autoloadable but may be not available at given path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-528) Fix crypto in unicode environment
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625071#action_12625071 ]
Chris Chabot commented on SHINDIG-528:
--------------------------------------
Fortunately the require was already removed, but the private -> protected switch wasn't yet ..*sigh* that's what you get for trying to cramp to many things into a afternoon. Thanks for paying attention for me and catching my mistakes :)
> Fix crypto in unicode environment
> ---------------------------------
>
> Key: SHINDIG-528
> URL: https://issues.apache.org/jira/browse/SHINDIG-528
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Environment: PHP uses mbstring.func_overload set to 7
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
> Attachments: unicode_crypto_patch.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This PHP setting automagically makes many string functions to work in unicode-compatible mode. However it's not very good when strings are used as byte arrays. Currently BasicBlobCrypter and Crypto classes do this, and thus are not compatible with this option. Attached patch fixes this.
> Also there're 2 more small fixes: protected, not private access for overridable config variables, removal of require of Crypto in BasicBlobCrypter, as it's autoloadable but may be not available at given path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-528) Fix crypto in unicode environment
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625067#action_12625067 ]
Artemy Tregubenko commented on SHINDIG-528:
-------------------------------------------
BTW, didn't you patched BasicBlobCrypter this time? There're some unsafe substrs.
> Fix crypto in unicode environment
> ---------------------------------
>
> Key: SHINDIG-528
> URL: https://issues.apache.org/jira/browse/SHINDIG-528
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Environment: PHP uses mbstring.func_overload set to 7
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
> Attachments: unicode_crypto_patch.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This PHP setting automagically makes many string functions to work in unicode-compatible mode. However it's not very good when strings are used as byte arrays. Currently BasicBlobCrypter and Crypto classes do this, and thus are not compatible with this option. Attached patch fixes this.
> Also there're 2 more small fixes: protected, not private access for overridable config variables, removal of require of Crypto in BasicBlobCrypter, as it's autoloadable but may be not available at given path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-528) Fix crypto in unicode environment
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625069#action_12625069 ]
Chris Chabot commented on SHINDIG-528:
--------------------------------------
There were a few patch errors so i merged the changes manually and I must have accidentally overlooked that part, committed it now.
> Fix crypto in unicode environment
> ---------------------------------
>
> Key: SHINDIG-528
> URL: https://issues.apache.org/jira/browse/SHINDIG-528
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Environment: PHP uses mbstring.func_overload set to 7
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
> Attachments: unicode_crypto_patch.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This PHP setting automagically makes many string functions to work in unicode-compatible mode. However it's not very good when strings are used as byte arrays. Currently BasicBlobCrypter and Crypto classes do this, and thus are not compatible with this option. Attached patch fixes this.
> Also there're 2 more small fixes: protected, not private access for overridable config variables, removal of require of Crypto in BasicBlobCrypter, as it's autoloadable but may be not available at given path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-528) Fix crypto in unicode environment
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625072#action_12625072 ]
Artemy Tregubenko commented on SHINDIG-528:
-------------------------------------------
Don't thank me, it's you who deserves to be praised : )
> Fix crypto in unicode environment
> ---------------------------------
>
> Key: SHINDIG-528
> URL: https://issues.apache.org/jira/browse/SHINDIG-528
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Environment: PHP uses mbstring.func_overload set to 7
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
> Attachments: unicode_crypto_patch.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This PHP setting automagically makes many string functions to work in unicode-compatible mode. However it's not very good when strings are used as byte arrays. Currently BasicBlobCrypter and Crypto classes do this, and thus are not compatible with this option. Attached patch fixes this.
> Also there're 2 more small fixes: protected, not private access for overridable config variables, removal of require of Crypto in BasicBlobCrypter, as it's autoloadable but may be not available at given path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-528) Fix crypto in unicode environment
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot resolved SHINDIG-528.
----------------------------------
Resolution: Fixed
Assignee: Chris Chabot
Thanks for the patch! Applied and committed.
Since you seem to have a good testing ground for what mbstring has on php shindig, did you run into any other issues with it?
> Fix crypto in unicode environment
> ---------------------------------
>
> Key: SHINDIG-528
> URL: https://issues.apache.org/jira/browse/SHINDIG-528
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (PHP)
> Environment: PHP uses mbstring.func_overload set to 7
> Reporter: Artemy Tregubenko
> Assignee: Chris Chabot
> Priority: Minor
> Attachments: unicode_crypto_patch.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This PHP setting automagically makes many string functions to work in unicode-compatible mode. However it's not very good when strings are used as byte arrays. Currently BasicBlobCrypter and Crypto classes do this, and thus are not compatible with this option. Attached patch fixes this.
> Also there're 2 more small fixes: protected, not private access for overridable config variables, removal of require of Crypto in BasicBlobCrypter, as it's autoloadable but may be not available at given path.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.