You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by John Barrett <jb...@slashdotmedia.com> on 2015/02/03 00:41:32 UTC
[allura:tickets] #7823 Commit activity is assigned to wrong person
---
** [tickets:#7823] Commit activity is assigned to wrong person**
**Status:** open
**Milestone:** unreleased
**Created:** Mon Feb 02, 2015 11:41 PM UTC by John Barrett
**Last Updated:** Mon Feb 02, 2015 11:41 PM UTC
**Owner:** nobody
Please see:
https://sourceforge.net/p/cjam/activity/?page=0&limit=100
The commits look like they were committed by someone else besides who actually committed them. I remember running into a similar issue before and the issue was that the commit didn't identify the author email address correctly and ended up showing the the closest account that matched as the committer. I can't remember process to prove that is the case. Please have someone look into this issue.
Thanks
SourceForge Support
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7823 Commit activity is assigned to wrong person
Posted by John Barrett <jb...@slashdotmedia.com>.
[forge:site-support:#9707]
https://sourceforge.net/p/forge/site-support/9707/
and
[forge:site-support:#9644]
https://sourceforge.net/p/forge/site-support/9644/
---
** [tickets:#7823] Commit activity is assigned to wrong person**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** 42cc sf-current sf-2
**Created:** Mon Feb 02, 2015 11:41 PM UTC by John Barrett
**Last Updated:** Tue Feb 10, 2015 09:13 AM UTC
**Owner:** Igor Bondarenko
Please see:
https://sourceforge.net/p/cjam/activity/?page=0&limit=100
The commits look like they were committed by someone else besides who actually committed them. I remember running into a similar issue before and the issue was that the commit didn't identify the author email address correctly and ended up showing the the closest account that matched as the committer. I can't remember process to prove that is the case. Please have someone look into this issue.
Thanks
SourceForge Support
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7823 Commit activity is assigned to wrong person
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: review --> closed
- **Reviewer**: Dave Brondsema
---
** [tickets:#7823] Commit activity is assigned to wrong person**
**Status:** closed
**Milestone:** unreleased
**Labels:** 42cc sf-current sf-2
**Created:** Mon Feb 02, 2015 11:41 PM UTC by John Barrett
**Last Updated:** Fri Feb 13, 2015 06:28 AM UTC
**Owner:** Igor Bondarenko
Please see:
https://sourceforge.net/p/cjam/activity/?page=0&limit=100
The commits look like they were committed by someone else besides who actually committed them. I remember running into a similar issue before and the issue was that the commit didn't identify the author email address correctly and ended up showing the the closest account that matched as the committer. I can't remember process to prove that is the case. Please have someone look into this issue.
Thanks
SourceForge Support
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7823 Commit activity is assigned to wrong person
Posted by John Barrett <jb...@slashdotmedia.com>.
More info from IRC support channel
aditsu
6:14 JBarrett11: there's also something weird at https://sourceforge.net/p/cjam/code/ci/2a0112fd06d417a56f514306feab960df5e85c2a/ - that commit only modified 1 file, nothing added
JBarrett11
6:14 hmm, odd
aditsu
6:15 .hgtags is duplicated apparently
JBarrett11
6:15 you made that commit just a couple of days ago?
aditsu
6:15 yeah
6:16 it's also one of the ones listed with the wrong user
6:16 it looks perfectly fine in my local repository
---
** [tickets:#7823] Commit activity is assigned to wrong person**
**Status:** open
**Milestone:** unreleased
**Created:** Mon Feb 02, 2015 11:41 PM UTC by John Barrett
**Last Updated:** Tue Feb 03, 2015 12:01 AM UTC
**Owner:** nobody
Please see:
https://sourceforge.net/p/cjam/activity/?page=0&limit=100
The commits look like they were committed by someone else besides who actually committed them. I remember running into a similar issue before and the issue was that the commit didn't identify the author email address correctly and ended up showing the the closest account that matched as the committer. I can't remember process to prove that is the case. Please have someone look into this issue.
Thanks
SourceForge Support
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7823 Commit activity is assigned to wrong person
Posted by Dave Brondsema <da...@brondsema.net>.
- **labels**: 42cc, sf-current, sf-2 --> 42cc, sf-2
---
** [tickets:#7823] Commit activity is assigned to wrong person**
**Status:** closed
**Milestone:** unreleased
**Labels:** 42cc sf-2
**Created:** Mon Feb 02, 2015 11:41 PM UTC by John Barrett
**Last Updated:** Mon Feb 23, 2015 03:45 PM UTC
**Owner:** Igor Bondarenko
Please see:
https://sourceforge.net/p/cjam/activity/?page=0&limit=100
The commits look like they were committed by someone else besides who actually committed them. I remember running into a similar issue before and the issue was that the commit didn't identify the author email address correctly and ended up showing the the closest account that matched as the committer. I can't remember process to prove that is the case. Please have someone look into this issue.
Thanks
SourceForge Support
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7823 Commit activity is assigned to wrong person
Posted by Dave Brondsema <da...@brondsema.net>.
- **labels**: --> sf-current, sf-2
---
** [tickets:#7823] Commit activity is assigned to wrong person**
**Status:** open
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Mon Feb 02, 2015 11:41 PM UTC by John Barrett
**Last Updated:** Thu Feb 05, 2015 02:50 PM UTC
**Owner:** nobody
Please see:
https://sourceforge.net/p/cjam/activity/?page=0&limit=100
The commits look like they were committed by someone else besides who actually committed them. I remember running into a similar issue before and the issue was that the commit didn't identify the author email address correctly and ended up showing the the closest account that matched as the committer. I can't remember process to prove that is the case. Please have someone look into this issue.
Thanks
SourceForge Support
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7823 Commit activity is assigned to wrong person
Posted by Dave Brondsema <da...@brondsema.net>.
`Glenn Randers-Pehrson <glennrp at users.sourceforge.net>` is another format to test and make sure is handled well. (From https://sourceforge.net/p/forge/site-support/9644/)
---
** [tickets:#7823] Commit activity is assigned to wrong person**
**Status:** review
**Milestone:** unreleased
**Labels:** 42cc sf-current sf-2
**Created:** Mon Feb 02, 2015 11:41 PM UTC by John Barrett
**Last Updated:** Thu Feb 12, 2015 02:13 PM UTC
**Owner:** Igor Bondarenko
Please see:
https://sourceforge.net/p/cjam/activity/?page=0&limit=100
The commits look like they were committed by someone else besides who actually committed them. I remember running into a similar issue before and the issue was that the commit didn't identify the author email address correctly and ended up showing the the closest account that matched as the committer. I can't remember process to prove that is the case. Please have someone look into this issue.
Thanks
SourceForge Support
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7823 Commit activity is assigned to wrong person
Posted by Igor Bondarenko <je...@gmail.com>.
- **status**: in-progress --> review
- **Comment**:
Closed #724. `ib/7823`
Changed `EmailAddress.canonical` to return None and fixed all the places which it affects.
forge-classic also uses it in [two places](https://sourceforge.net/p/allura/pastebin/54dcb48c85540d521ea3f26d), but always with valid emails (sf aliases), so should not be any problems there.
---
** [tickets:#7823] Commit activity is assigned to wrong person**
**Status:** review
**Milestone:** unreleased
**Labels:** 42cc sf-current sf-2
**Created:** Mon Feb 02, 2015 11:41 PM UTC by John Barrett
**Last Updated:** Thu Feb 12, 2015 01:52 AM UTC
**Owner:** Igor Bondarenko
Please see:
https://sourceforge.net/p/cjam/activity/?page=0&limit=100
The commits look like they were committed by someone else besides who actually committed them. I remember running into a similar issue before and the issue was that the commit didn't identify the author email address correctly and ended up showing the the closest account that matched as the committer. I can't remember process to prove that is the case. Please have someone look into this issue.
Thanks
SourceForge Support
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Re: #7823 Commit activity is assigned to wrong person
Posted by aditsu <No...@allura-vm.apache.org>.
Ok I pushed a new commit and this time it credited "dSoft®". There's definitely something wrong going on now and it wasn't happening a couple of months ago.
---
** [tickets:#7823] Commit activity is assigned to wrong person**
**Status:** open
**Milestone:** unreleased
**Created:** Mon Feb 02, 2015 11:41 PM UTC by John Barrett
**Last Updated:** Wed Feb 04, 2015 05:26 PM UTC
**Owner:** nobody
Please see:
https://sourceforge.net/p/cjam/activity/?page=0&limit=100
The commits look like they were committed by someone else besides who actually committed them. I remember running into a similar issue before and the issue was that the commit didn't identify the author email address correctly and ended up showing the the closest account that matched as the committer. I can't remember process to prove that is the case. Please have someone look into this issue.
Thanks
SourceForge Support
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Re: #7823 Commit activity is assigned to wrong person
Posted by aditsu <No...@allura-vm.apache.org>.
Hi, I'm the affected user. There's nothing special about those commits, as I never put my email address in there, and I never had this kind of problem before.
The only thing that's different is that the servers were having some serious problems while I was pushing those commits.
I can try to push some more stuff and see if it happens again. If it does, it means you broke something on your side in the last month or two.
---
** [tickets:#7823] Commit activity is assigned to wrong person**
**Status:** open
**Milestone:** unreleased
**Created:** Mon Feb 02, 2015 11:41 PM UTC by John Barrett
**Last Updated:** Tue Feb 03, 2015 04:26 PM UTC
**Owner:** nobody
Please see:
https://sourceforge.net/p/cjam/activity/?page=0&limit=100
The commits look like they were committed by someone else besides who actually committed them. I remember running into a similar issue before and the issue was that the commit didn't identify the author email address correctly and ended up showing the the closest account that matched as the committer. I can't remember process to prove that is the case. Please have someone look into this issue.
Thanks
SourceForge Support
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7823 Commit activity is assigned to wrong person
Posted by Dave Brondsema <da...@brondsema.net>.
Looks like the mercurial commits in question just have a username, no email address associated with them. And our `EmailAddress.canonical` defaults to 'nobody@example.com' which happened to match with an existing user.
We should change how we handle commits without email addresses. And maybe also not default to 'nobody@example.com'. (would have to assess impact of an exception or other return value)
---
** [tickets:#7823] Commit activity is assigned to wrong person**
**Status:** open
**Milestone:** unreleased
**Created:** Mon Feb 02, 2015 11:41 PM UTC by John Barrett
**Last Updated:** Tue Feb 03, 2015 01:18 AM UTC
**Owner:** nobody
Please see:
https://sourceforge.net/p/cjam/activity/?page=0&limit=100
The commits look like they were committed by someone else besides who actually committed them. I remember running into a similar issue before and the issue was that the commit didn't identify the author email address correctly and ended up showing the the closest account that matched as the committer. I can't remember process to prove that is the case. Please have someone look into this issue.
Thanks
SourceForge Support
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7823 Commit activity is assigned to wrong person
Posted by John Barrett <jb...@slashdotmedia.com>.
Suggested from IRC Regular (wjp)
Commit.author_url calls User.by_email_address calls EmailAddress.canonical, which will return nobody@example.com for invalid addresses, which gets passed to query.find(), possibly returning a random user with email address set to nobody@example.com?
---
** [tickets:#7823] Commit activity is assigned to wrong person**
**Status:** open
**Milestone:** unreleased
**Created:** Mon Feb 02, 2015 11:41 PM UTC by John Barrett
**Last Updated:** Mon Feb 02, 2015 11:41 PM UTC
**Owner:** nobody
Please see:
https://sourceforge.net/p/cjam/activity/?page=0&limit=100
The commits look like they were committed by someone else besides who actually committed them. I remember running into a similar issue before and the issue was that the commit didn't identify the author email address correctly and ended up showing the the closest account that matched as the committer. I can't remember process to prove that is the case. Please have someone look into this issue.
Thanks
SourceForge Support
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.