Re: [PR] [AMORO-2629]Mixed hive refractor [amoro]

["Aireed (via GitHub)" <gi...@apache.org>]

Aireed commented on code in PR #2691:
URL: https://github.com/apache/amoro/pull/2691#discussion_r1559098666


##########
ams/server/src/test/java/com/netease/arctic/server/table/TestTableRuntimeHandler.java:
##########
@@ -66,12 +66,15 @@ public TestTableRuntimeHandler(
   }
 
   @Test
-  public void testInitialize() {
+  public void testInitialize() throws Exception {
     tableService = new DefaultTableService(new Configurations());
     TestHandler handler = new TestHandler();
     tableService.addHandlerChain(handler);
     tableService.initialize();
-    createDatabase();
+    if (!(catalogTestHelper().tableFormat().equals(TableFormat.MIXED_HIVE)
+        && TEST_HMS.getHiveClient().getDatabase(TableTestHelper.TEST_DB_NAME) != null)) {
+      createDatabase();
+    }

Review Comment:
   AMSTableTestBase::init  will  create the database  create test_db in advance. An error indicating the existence of the database will be reported here.
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org