You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/08/16 23:13:44 UTC
Review Request 61705: Added a mock CSI plugin and a unit test for CSI
client classes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61705/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: mesos-7491
https://issues.apache.org/jira/browse/mesos-7491
Repository: mesos
Description
-------
The mock plugin simply starts the `Identity`, `Controller` and `Node`
CSI services and return a success with an empty response protocol buffer
for each RPC. The unit test verifies that each method in the CSI client
classes makes the corresponding RPC call through the gRPC interface in
libprocess.
Diffs
-----
src/tests/csi_client_tests.cpp PRE-CREATION
src/tests/mock_csi_plugin.hpp PRE-CREATION
src/tests/mock_csi_plugin.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/61705/diff/1/
Testing
-------
Tests described in r/61706.
Thanks,
Chun-Hung Hsiao
Re: Review Request 61705: Added a mock CSI plugin and a unit test for
CSI client classes.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61705/#review183195
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/csi_client_tests.cpp
Lines 50 (patched)
<https://reviews.apache.org/r/61705/#comment259212>
instead of using `pair`, i'd prefer an explicit struct to make it more readable:
```
struct RPC
{
string name;
lambda::function<Future<Nothing>(const string&)> call;
};
class CSIClientTest
: public TemporaryDirectoryTest,
public WithParamInterface<RPC>
{
...
};
```
src/tests/csi_client_tests.cpp
Lines 104 (patched)
<https://reviews.apache.org/r/61705/#comment259210>
2 lines apart.
src/tests/csi_client_tests.cpp
Lines 140 (patched)
<https://reviews.apache.org/r/61705/#comment259211>
`{` in the next line.
- Jie Yu
On Aug. 16, 2017, 11:13 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61705/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2017, 11:13 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: mesos-7491
> https://issues.apache.org/jira/browse/mesos-7491
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The mock plugin simply starts the `Identity`, `Controller` and `Node`
> CSI services and return a success with an empty response protocol buffer
> for each RPC. The unit test verifies that each method in the CSI client
> classes makes the corresponding RPC call through the gRPC interface in
> libprocess.
>
>
> Diffs
> -----
>
> src/tests/csi_client_tests.cpp PRE-CREATION
> src/tests/mock_csi_plugin.hpp PRE-CREATION
> src/tests/mock_csi_plugin.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61705/diff/1/
>
>
> Testing
> -------
>
> Tests described in r/61706.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61705: Added a mock CSI plugin and a unit test for
CSI client classes.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61705/#review183517
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 19, 2017, 12:37 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61705/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2017, 12:37 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: mesos-7491
> https://issues.apache.org/jira/browse/mesos-7491
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The mock plugin simply starts the `Identity`, `Controller` and `Node`
> CSI services and return a success with an empty response protocol buffer
> for each RPC. The unit test verifies that each method in the `Client`
> class makes the corresponding RPC call through the gRPC interface in
> libprocess.
>
>
> Diffs
> -----
>
> src/tests/csi_client_tests.cpp PRE-CREATION
> src/tests/mock_csi_plugin.hpp PRE-CREATION
> src/tests/mock_csi_plugin.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61705/diff/2/
>
>
> Testing
> -------
>
> Tests described in r/61706.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61705: Added a mock CSI plugin and a unit test for
CSI client classes.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61705/
-----------------------------------------------------------
(Updated Aug. 19, 2017, 12:37 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Addressed @jieyu's comments.
Bugs: mesos-7491
https://issues.apache.org/jira/browse/mesos-7491
Repository: mesos
Description (updated)
-------
The mock plugin simply starts the `Identity`, `Controller` and `Node`
CSI services and return a success with an empty response protocol buffer
for each RPC. The unit test verifies that each method in the `Client`
class makes the corresponding RPC call through the gRPC interface in
libprocess.
Diffs (updated)
-----
src/tests/csi_client_tests.cpp PRE-CREATION
src/tests/mock_csi_plugin.hpp PRE-CREATION
src/tests/mock_csi_plugin.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/61705/diff/2/
Changes: https://reviews.apache.org/r/61705/diff/1-2/
Testing
-------
Tests described in r/61706.
Thanks,
Chun-Hung Hsiao
Re: Review Request 61705: Added a mock CSI plugin and a unit test for
CSI client classes.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61705/#review183085
-----------------------------------------------------------
Bad patch!
Reviews applied: [61705, 61704, 61703, 61600]
Failed command: python support/apply-reviews.py -n -r 61703
Error:
error: missing binary patch data for '3rdparty/csi-0.1.0.tar.gz'
error: binary patch does not apply to '3rdparty/csi-0.1.0.tar.gz'
error: 3rdparty/csi-0.1.0.tar.gz: patch does not apply
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/240/console
- Mesos Reviewbot Windows
On Aug. 16, 2017, 4:13 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61705/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2017, 4:13 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: mesos-7491
> https://issues.apache.org/jira/browse/mesos-7491
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The mock plugin simply starts the `Identity`, `Controller` and `Node`
> CSI services and return a success with an empty response protocol buffer
> for each RPC. The unit test verifies that each method in the CSI client
> classes makes the corresponding RPC call through the gRPC interface in
> libprocess.
>
>
> Diffs
> -----
>
> src/tests/csi_client_tests.cpp PRE-CREATION
> src/tests/mock_csi_plugin.hpp PRE-CREATION
> src/tests/mock_csi_plugin.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61705/diff/1/
>
>
> Testing
> -------
>
> Tests described in r/61706.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>