You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/19 18:59:27 UTC

[GitHub] apeforest commented on a change in pull request #13260: Support full convention in quantized pooling

apeforest commented on a change in pull request #13260: Support full convention in quantized pooling
URL: https://github.com/apache/incubator-mxnet/pull/13260#discussion_r234741341
 
 

 ##########
 File path: tests/python/quantization/test_quantization.py
 ##########
 @@ -214,7 +214,7 @@ def check_quantized_conv(data_shape, kernel, num_filter, pad, stride, no_bias, q
 
 @with_seed()
 def test_quantized_pooling():
-    def check_quantized_pooling(data_shape, kernel, pool_type, pad, stride, global_pool, qdtype):
+    def check_quantized_pooling(data_shape, kernel, pool_type, pad, stride, global_pool, qdtype, convention):
 
 Review comment:
   I suggest we keep this test to test the default behavior without passing in convention. Add another test to pass in convention as an extra argument.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services