You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/06/11 22:26:03 UTC
[GitHub] [incubator-apisix-dashboard] juzhiyuan opened a new pull request #256: feat: added Dashboard dockerfile
juzhiyuan opened a new pull request #256:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #256: feat: added Dashboard dockerfile
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #256:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] gxthrj commented on a change in pull request #256: feat: added Dashboard dockerfile
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #256:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/256#discussion_r439171814
##########
File path: compose/docker-compose.yml
##########
@@ -82,16 +82,16 @@ services:
ipv4_address: 192.17.5.15
- # dashboard:
- # build:
- # context: ./..
- # dockerfile: Dockerfile
- # restart: always
- # ports:
- # - "80:80/tcp"
- # networks:
- # apisix-dashboard:
- # ipv4_address: 192.17.5.16
+ dashboard:
+ build:
+ context: ./..
+ dockerfile: Dockerfile
+ restart: always
+ ports:
+ - "80:80/tcp"
+ networks:
+ apisix-dashboard:
+ ipv4_address: 192.17.5.16
Review comment:
networks and IP is not necessary in dashboard,you can remove the networks field
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #256: feat: added Dashboard dockerfile
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #256:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/256#issuecomment-642962252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #256: feat: added Dashboard dockerfile
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #256:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/256#discussion_r439106667
##########
File path: compose/docker-compose.yml
##########
@@ -82,16 +82,16 @@ services:
ipv4_address: 192.17.5.15
- # dashboard:
- # build:
- # context: ./..
- # dockerfile: Dockerfile
- # restart: always
- # ports:
- # - "80:80/tcp"
- # networks:
- # apisix-dashboard:
- # ipv4_address: 192.17.5.16
+ dashboard:
+ build:
+ context: ./..
+ dockerfile: Dockerfile
+ restart: always
+ ports:
+ - "80:80/tcp"
+ networks:
+ apisix-dashboard:
+ ipv4_address: 192.17.5.16
Review comment:
too wired 🤔 is it a fixed IP address? @kv
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org